diff options
| author | Florian Pritz <bluewind@xinu.at> | 2018-08-02 14:23:37 +0200 |
|---|---|---|
| committer | Florian Pritz <bluewind@xinu.at> | 2018-08-02 14:23:41 +0200 |
| commit | 666aac46090e6484d8866d477bb5eceafb4ef3f8 (patch) | |
| tree | d35d6eba071e64293e9367d053c0ee1e58b31e53 | |
| parent | 84d8ca4dd7f008abdb4ca59ccfb416fe820a5753 (diff) | |
| download | App-BorgRestore-666aac46090e6484d8866d477bb5eceafb4ef3f8.tar.gz App-BorgRestore-666aac46090e6484d8866d477bb5eceafb4ef3f8.tar.xz | |
Remove sqlite cache size warning
The original performance problem on my machine doesn't seem to be
reproducable any more so maybe either sqlite got smarter or it was
something else entirely. Move the warning to DEBUG and soften the
documentation. If it still helps people can use it, but we don't have to
annoy them if it doesn't.
Signed-off-by: Florian Pritz <bluewind@xinu.at>
| -rw-r--r-- | lib/App/BorgRestore/DB.pm | 4 | ||||
| -rw-r--r-- | lib/App/BorgRestore/Settings.pm | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/lib/App/BorgRestore/DB.pm b/lib/App/BorgRestore/DB.pm index 177df27..fe8feea 100644 --- a/lib/App/BorgRestore/DB.pm +++ b/lib/App/BorgRestore/DB.pm @@ -175,8 +175,8 @@ method verify_cache_fill_rate_ok() { my $used = $self->{dbh}->sqlite_db_status()->{cache_used}->{current}; $log->debugf("sqlite page cache usage: %s", format_bytes($used, si=>1)); if ($used > $self->{cache_size} * 1024 * 0.95) { - $log->warnf("sqlite cache usage is %s of %s", format_bytes($used, si=>1), format_bytes($self->{cache_size} * 1024, si => 1)); - $log->warn("Consider increasing the sqlite cache (see documentation of App::BorgRestore::Settings)"); + $log->debugf("sqlite cache usage is %s of %s", format_bytes($used, si=>1), format_bytes($self->{cache_size} * 1024, si => 1)); + $log->debug("Consider increasing the sqlite cache if you notice performance issues (see documentation of App::BorgRestore::Settings)"); } } diff --git a/lib/App/BorgRestore/Settings.pm b/lib/App/BorgRestore/Settings.pm index e0979cb..faad58f 100644 --- a/lib/App/BorgRestore/Settings.pm +++ b/lib/App/BorgRestore/Settings.pm @@ -75,9 +75,9 @@ If you create a backup of /home/user only, you will need to use the following: Default: 102400 -The size of the in-memory cache of sqlite in kibibytes. This should be large -enough to fit the database so that adding new backup data does not need to use -the disk too much. +The size of the in-memory cache of sqlite in kibibytes. Increasing this may +reduce disk IO and improve performance on certain systems when updating the +cache. =back |