summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan McGee <dan@archlinux.org>2011-01-09 21:36:20 +0100
committerDan McGee <dan@archlinux.org>2011-01-09 21:36:20 +0100
commit76a986b0dbfdd9b5978c20b89a591ba519ddeee5 (patch)
tree579faa12062b685671c2421b6210c5875b962efc
parent2cc75b6939b43162a9c60f7d12159c7a1c9a707e (diff)
downloadarchweb-76a986b0dbfdd9b5978c20b89a591ba519ddeee5.tar.gz
archweb-76a986b0dbfdd9b5978c20b89a591ba519ddeee5.tar.xz
gjslint recommended javascript cleanups
Signed-off-by: Dan McGee <dan@archlinux.org>
-rw-r--r--media/archweb.js54
1 files changed, 28 insertions, 26 deletions
diff --git a/media/archweb.js b/media/archweb.js
index 1c80ab6..28398c4 100644
--- a/media/archweb.js
+++ b/media/archweb.js
@@ -1,6 +1,6 @@
/* tablesorter custom parsers for various pages:
* devel/index.html, mirrors/status.html, todolists/view.html */
-if(typeof $.tablesorter !== "undefined") {
+if (typeof $.tablesorter !== 'undefined') {
$.tablesorter.addParser({
id: 'pkgcount',
is: function(s) { return false; },
@@ -21,14 +21,14 @@ if(typeof $.tablesorter !== "undefined") {
$.tablesorter.addParser({
/* sorts numeric, but put '', 'unknown', and '∞' last. */
id: 'mostlydigit',
- is: function(s,table) {
+ is: function(s, table) {
var special = ['', 'unknown', '∞'];
var c = table.config;
- return ($.inArray(s, special) > -1) || $.tablesorter.isDigit(s,c);
+ return ($.inArray(s, special) > -1) || $.tablesorter.isDigit(s, c);
},
format: function(s) {
var special = ['', 'unknown', '∞'];
- if($.inArray(s, special) > -1) return Number.MAX_VALUE;
+ if ($.inArray(s, special) > -1) return Number.MAX_VALUE;
return $.tablesorter.formatFloat(s);
},
type: 'numeric'
@@ -43,7 +43,7 @@ if(typeof $.tablesorter !== "undefined") {
},
format: function(s) {
var special = ['', 'unknown', '∞'];
- if($.inArray(s, special) > -1) return Number.MAX_VALUE;
+ if ($.inArray(s, special) > -1) return Number.MAX_VALUE;
var matches = this.re.exec(s);
return matches[1] * 60 + matches[2];
},
@@ -52,17 +52,17 @@ if(typeof $.tablesorter !== "undefined") {
$.tablesorter.addParser({
id: 'longDateTime',
re: /^(\d{4})-(\d{2})-(\d{2}) ([012]\d):([0-5]\d)(:([0-5]\d))?( (\w+))?$/,
- is: function (s) {
+ is: function(s) {
return this.re.test(s);
},
- format: function (s) {
+ format: function(s) {
var matches = this.re.exec(s);
/* skip group 6, group 7 is optional seconds */
- if(matches[7] == undefined) matches[7] = "0";
+ if (matches[7] == undefined) matches[7] = '0';
return $.tablesorter.formatFloat(new Date(
matches[1],matches[2],matches[3],matches[4],matches[5],matches[7]).getTime());
},
- type: "numeric"
+ type: 'numeric'
});
}
@@ -94,16 +94,16 @@ function ajaxifyFiles() {
/* packages/differences.html */
filter_packages = function() {
// start with all rows, and then remove ones we shouldn't show
- var rows = $("#tbody_differences").children();
+ var rows = $('#tbody_differences').children();
var all_rows = rows;
- if(!$('#id_multilib').is(':checked')) {
- rows = rows.not(".multilib").not(".multilib-testing");
+ if (!$('#id_multilib').is(':checked')) {
+ rows = rows.not('.multilib').not('.multilib-testing');
}
- var arch = $("#id_archonly").val();
- if(arch !== "all") {
- rows = rows.filter("." + arch);
+ var arch = $('#id_archonly').val();
+ if (arch !== 'all') {
+ rows = rows.filter('.' + arch);
}
- if(!$('#id_minor').is(':checked')) {
+ if (!$('#id_minor').is(':checked')) {
// this check is done last because it is the most expensive
var pat = /(.*)-(.+)/;
rows = rows.filter(function(index) {
@@ -111,15 +111,15 @@ filter_packages = function() {
// all this just to get the split version out of the table cell
var ver_a = cells.eq(2).find('span').text().match(pat);
- if(!ver_a) return true;
+ if (!ver_a) return true;
var ver_b = cells.eq(3).find('span').text().match(pat);
- if(!ver_b) return true;
+ if (!ver_b) return true;
// first check pkgver
- if(ver_a[1] !== ver_b[1]) return true;
+ if (ver_a[1] !== ver_b[1]) return true;
// pkgver matched, so see if rounded pkgrel matches
- if(Math.floor(parseFloat(ver_a[2])) ==
+ if (Math.floor(parseFloat(ver_a[2])) ==
Math.floor(parseFloat(ver_b[2]))) return false;
// pkgrel didn't match, so keep the row
return true;
@@ -129,12 +129,12 @@ filter_packages = function() {
all_rows.hide();
rows.show();
// make sure we update the odd/even styling from sorting
- $('.results').trigger("applyWidgets");
+ $('.results').trigger('applyWidgets');
};
filter_reset = function() {
- $('#id_archonly').val("both");
- $('#id_multilib').removeAttr("checked");
- $('#id_minor').removeAttr("checked");
+ $('#id_archonly').val('both');
+ $('#id_multilib').removeAttr('checked');
+ $('#id_minor').removeAttr('checked');
filter_packages();
};
@@ -143,9 +143,11 @@ todolist_flag = function() {
var link = this;
$.getJSON(link.href, function(data) {
if (data.complete) {
- $(link).text('Complete').addClass('complete').removeClass('incomplete');
+ $(link).text('Complete').addClass(
+ 'complete').removeClass('incomplete');
} else {
- $(link).text('Incomplete').addClass('incomplete').removeClass('complete');
+ $(link).text('Incomplete').addClass(
+ 'incomplete').removeClass('complete');
}
});
return false;