summaryrefslogtreecommitdiffstats
path: root/todolists/views.py
AgeCommit message (Collapse)AuthorFilesLines
2013-11-07Django 1.6 upgrade, deprecation cleanupDan McGee1-1/+1
PendingDeprecationWarning: commit_on_success is deprecated in favor of atomic. Signed-off-by: Dan McGee <dan@archlinux.org>
2013-05-11Add a 'last touched by' column to todolist detail viewDan McGee1-2/+3
This allows you to see very easily who last manipulated a package todolist item in case you have a need to know. Signed-off-by: Dan McGee <dan@archlinux.org>
2013-04-17Various minor code cleanups and fixesDan McGee1-1/+0
Most of these were suggested by PyCharm, and include everything from little syntax issues and other bad smells to dead or bad code. Signed-off-by: Dan McGee <dan@archlinux.org>
2013-03-12Only show incomplete todolists to unauthenticated usersDan McGee1-1/+2
Signed-off-by: Dan McGee <dan@archlinux.org>
2013-03-12Remove public todolists viewDan McGee1-10/+0
Replace this with a redirect to the developer todolist index page. Signed-off-by: Dan McGee <dan@archlinux.org>
2013-03-07Fix IntegrityError in corner case todolist updateDan McGee1-6/+19
We were seeing this in production: IntegrityError: duplicate key value violates unique constraint "todolists_todolistpackage_todolist_id_700d1b623414814c_uniq" DETAIL: Key (todolist_id, pkgname, arch_id)=(206, ruby-cairo, 2) already exists. This is due to a corner case where a package was originally on a todolist and the underlying package object disappeared, so the todolist entry was unlinked and pkg_id set to NULL. Later, this package came back, but our get_or_create tried to create an object that violated our unique constraint because of the missing pkg_id. Call get_or_create with the minimum necessary bits to find the todolist package object, and pass the rest of the values via defaults to avoid this problem. Additionally, relink any todolist entries up to a package in the repositories if one is available. Signed-off-by: Dan McGee <dan@archlinux.org>
2013-02-27Merge branch 'django-1.5'Dan McGee1-1/+1
Conflicts: requirements.txt requirements_prod.txt
2013-02-09Use 'update_fields' model.save() kwargDan McGee1-1/+1
This was added in Django 1.5 and allows saving only a subset of a model's fields. It makes sense in a few cases to utilize it. Signed-off-by: Dan McGee <dan@archlinux.org>
2013-02-09Ensure todolists are consistently sortedDan McGee1-1/+2
This is for the public view page; we had no order_by() call so lists could be displayed in seemingly random order. Signed-off-by: Dan McGee <dan@archlinux.org>
2013-01-22Show staging version on todolist view pageDan McGee1-1/+2
If one exists, it is easy enough to show it here so in-progress todolists can easily be cross-checked with the current state of the repository. Signed-off-by: Dan McGee <dan@archlinux.org>
2013-01-14Use content_type and not mimetype on HttpResponse()Dan McGee1-3/+2
Bug #16519 in Django deprecates mimetype, so update our code accordingly. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-12-31Set user on todolist packages when flag status changesDan McGee1-0/+1
This will allow us to see who last changed the status of a todolist item. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-12-31Mark todolist packages as removed rather than deleting themDan McGee1-19/+31
This makes it easier to see the progression of a todolist and its contents easier since we are no longer losing the data. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-12-31Minor coding style tweaksDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2012-12-29Defer the 'raw' field when listing todolistsDan McGee1-1/+1
A lot like skipping fetching of the news content; we definitely don't need this just to list the todolists on index pages. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-12-28Set slug on todolist creationDan McGee1-2/+6
Signed-off-by: Dan McGee <dan@archlinux.org>
2012-12-28Use todolist slugs for all URLsDan McGee1-14/+22
Signed-off-by: Dan McGee <dan@archlinux.org>
2012-12-28Todolist URLs map to old_id now, not idDan McGee1-4/+4
This is a short-term fix before adding a slug field to todo lists as we did to news a while back. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-12-28Convert to using new todolist models everywhereDan McGee1-33/+43
This is a rather widespread set of changes converting usage to the new todo list and todo list package model recently introduced. The data migration is not included in this commit. After this commit, the old model should no longer be referenced anywhere. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-11-16Use python set comprehension syntax supported in 2.7Dan McGee1-4/+4
Signed-off-by: Dan McGee <dan@archlinux.org>
2012-07-25Add arch and repo filter to todolist packagesDan McGee1-0/+4
This matches what we do on signoffs. Also beef up the styling a bit and add the dynamically updated package count info. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-07-25Replace deprecated direct_to_template() with render() shortcutDan McGee1-7/+6
Now that Django actually provides a concise way to use a RequestContext object without instantiating it, we can use that rather than the old function-based generic view that worked well to do the same. Additionally, these function-based generic views will be gone in Django 1.5, so might as well make the move now. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-07-24Add blank description to todo list creation and editingDan McGee1-0/+2
This is a field shown on the general_form.html, and shows up as @@@INVALID@@@ in development environments. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-05-12Use python json module directly in place of simplejsonDan McGee1-3/+3
As of Python 2.6, this is a builtin module that has all the same functions and capabilities of the Django simplejson module. Additionally simplejson is deprecated in the upcoming Django 1.5 release. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-05-02Ensure order_by default value is cleared when using distinct()Dan McGee1-2/+2
Otherwise the queryset returns nonsensical results. I find the design of this less than obvious but so be it; we can ensure the results work regardless of a default ordering on the model. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-01-05Adjust page and content caching lengths and decoratorsDan McGee1-2/+0
Remove never_cache from many places now that we don't actually need it since we aren't caching by default. Adjust our cache_function decorator times be shorter values, and also randomize them a bit to make cache invalidations not all line up. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-01-04Add new todolist pkgbase list viewDan McGee1-8/+23
This is for use after rebuilds when moving packages out of the staging and testing repositories. Signed-off-by: Dan McGee <dan@archlinux.org>
2011-11-04Make maintainer lookup on todo lists fastDan McGee1-1/+7
This is rather sick to look at. Sorry, Django gives me no other choice. Signed-off-by: Dan McGee <dan@archlinux.org>
2011-06-24Don't include staging packages in todolistsDan McGee1-2/+2
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-05-04Fix missed list -> todolist variable renameDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-04-09Show more info about todolists on developer dashboardDan McGee1-14/+3
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-04-09Rename local variables for clarityDan McGee1-6/+6
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-04-08Convert todolist delete to class-based viewDan McGee1-8/+6
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-03-04Send only one email per todolistDan McGee1-26/+28
Customize each email on a per-maintainer basis and list all the relevant packages inside, rather than spamming people. Signed-off-by: Dan McGee <dan@archlinux.org>
2011-03-04Use transactions in todolist creationDan McGee1-42/+52
So we do all of the work at once and don't let things leak out before the list is completely added or updated. Signed-off-by: Dan McGee <dan@archlinux.org>
2011-03-03Correct some permission decoratorsDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-10-04Todo list minor fixes and comments for laterDan McGee1-6/+8
When we show the edit todo list page, use a sorted list retrieved straight from the database instead of a unordered set() we create at the application level. Also add some comments for potential later improvements on transaction boundaries and async emailing. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-09-09Improve todo list view pageDan McGee1-3/+12
Add total package count and incomplete package count columns. Also reduce the number of total queries by killing the query per row that was happening before. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-09-03Use direct_to_template in all remaining possible placesDan McGee1-13/+10
Rather than the need to include RequestContext() calls directly, we can just use direct_to_template to do all the work for us. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-07-25Add a basic view for todo listsDusty Phillips1-0/+5
Dan: rename template and view to something a bit more concise. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-07-06Add absolute URL method for todo listsDan McGee1-3/+3
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-28Mark the todolists' flag view as never_cacheEvangelos Foutras1-2/+1
Also remove the @vary_on_headers('X-Requested-With') since it's irrelevant now. Dan: remove now unnecessary import. Signed-off-by: Evangelos Foutras <foutrelis@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-25Mark a few more pages as never cacheDan McGee1-0/+2
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-22Add 'never_cache' decorator in a bunch of placesDan McGee1-0/+4
Now that we cache everything, we need to ensure anyone doing edits and such gets the live data and not some cached version that was already updated and is now stale. Add the never_cache decorator to any of the CUD screens as well as a few others that might benefit from always being regenerated. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-08Use Sites framework instead of hardcoded domain nameDan McGee1-1/+1
Instead of putting 'www.archlinux.org' all over the place, use the Django sites framework to pull the site name out of the database. Now these amazing things will work if you are running locally and decide to change the site! Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-02Rename todolist email templateDan McGee1-1/+1
More in line with our other templates that have .txt extensions. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-05-21Fix undefined variable issueDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-04-03Fix package URL in todo list emailsDan McGee1-1/+1
Fixes FS#18935. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-03-30Fix todolist dealing with package maintainersDan McGee1-3/+3
Forgot to update this, whoops. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-03-06Use repo.testing flag instead of test-based checksDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
generated by cgit v1.2.3-24-g4f1b (git 2.32.0) at 2024-11-14 00:08:24 +0100