summaryrefslogtreecommitdiffstats
path: root/todolists
AgeCommit message (Collapse)AuthorFilesLines
2012-11-21Improve performance of todolists queryDan McGee1-15/+26
Use some standard SQL and split the query into two different parts to save a lot of unnecessary sorting and field retrieval at the database level. The `CASE WHEN complete THEN 1 ELSE 0 END` syntax should be accepted by any database that implements proper SQL; it was tested in PostgreSQL and sqlite3 without issues. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-11-16Use python set comprehension syntax supported in 2.7Dan McGee1-4/+4
Signed-off-by: Dan McGee <dan@archlinux.org>
2012-07-25Add arch and repo filter to todolist packagesDan McGee1-0/+4
This matches what we do on signoffs. Also beef up the styling a bit and add the dynamically updated package count info. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-07-25Replace deprecated direct_to_template() with render() shortcutDan McGee1-7/+6
Now that Django actually provides a concise way to use a RequestContext object without instantiating it, we can use that rather than the old function-based generic view that worked well to do the same. Additionally, these function-based generic views will be gone in Django 1.5, so might as well make the move now. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-07-24Add blank description to todo list creation and editingDan McGee1-0/+2
This is a field shown on the general_form.html, and shows up as @@@INVALID@@@ in development environments. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-05-12Use python json module directly in place of simplejsonDan McGee1-3/+3
As of Python 2.6, this is a builtin module that has all the same functions and capabilities of the Django simplejson module. Additionally simplejson is deprecated in the upcoming Django 1.5 release. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-05-02Ensure order_by default value is cleared when using distinct()Dan McGee1-2/+2
Otherwise the queryset returns nonsensical results. I find the design of this less than obvious but so be it; we can ensure the results work regardless of a default ordering on the model. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-04-27Incomplete-only todolists optimizationDan McGee1-2/+6
We can push this down to the database if we know in advance we only need the incomplete lists. This helps our call on the developer dashboard quite a bit; the time of the single query in question drops from >1300ms to around 40ms. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-04-07Prevent selection of many useless fields when getting todolistsDan McGee1-1/+5
This is a bit of a hack, but makes the resulting resultset returned from the database a lot smaller and kills off all the columns we don't care about and would never look at. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-03-24Change Django urls.py importDan McGee1-1/+1
Until Django 1.3, the functions include(), patterns() and url() plus handler404, handler500 were located in a django.conf.urls.defaults module. In Django 1.4, they live in django.conf.urls. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-01-05Adjust page and content caching lengths and decoratorsDan McGee1-2/+0
Remove never_cache from many places now that we don't actually need it since we aren't caching by default. Adjust our cache_function decorator times be shorter values, and also randomize them a bit to make cache invalidations not all line up. Signed-off-by: Dan McGee <dan@archlinux.org>
2012-01-04Add new todolist pkgbase list viewDan McGee2-9/+25
This is for use after rebuilds when moving packages out of the staging and testing repositories. Signed-off-by: Dan McGee <dan@archlinux.org>
2011-11-04Make maintainer lookup on todo lists fastDan McGee1-1/+7
This is rather sick to look at. Sorry, Django gives me no other choice. Signed-off-by: Dan McGee <dan@archlinux.org>
2011-06-24Don't include staging packages in todolistsDan McGee1-2/+2
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-05-04Fix missed list -> todolist variable renameDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-04-09Show more info about todolists on developer dashboardDan McGee3-15/+23
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-04-09Rename local variables for clarityDan McGee1-6/+6
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-04-08Convert todolist delete to class-based viewDan McGee2-10/+11
Signed-off-by: Dan McGee <dan@archlinux.org>
2011-03-04Send only one email per todolistDan McGee1-26/+28
Customize each email on a per-maintainer basis and list all the relevant packages inside, rather than spamming people. Signed-off-by: Dan McGee <dan@archlinux.org>
2011-03-04Use transactions in todolist creationDan McGee1-42/+52
So we do all of the work at once and don't let things leak out before the list is completely added or updated. Signed-off-by: Dan McGee <dan@archlinux.org>
2011-03-03Correct some permission decoratorsDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-12-13Move more URLs out of root urlconfDan McGee1-0/+13
Things are a bit cleaner now. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-10-04Todo list minor fixes and comments for laterDan McGee1-6/+8
When we show the edit todo list page, use a sorted list retrieved straight from the database instead of a unordered set() we create at the application level. Also add some comments for potential later improvements on transaction boundaries and async emailing. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-09-09Improve todo list view pageDan McGee1-3/+12
Add total package count and incomplete package count columns. Also reduce the number of total queries by killing the query per row that was happening before. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-09-03Use direct_to_template in all remaining possible placesDan McGee1-13/+10
Rather than the need to include RequestContext() calls directly, we can just use direct_to_template to do all the work for us. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-07-25Add a basic view for todo listsDusty Phillips1-0/+5
Dan: rename template and view to something a bit more concise. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-07-06Add absolute URL method for todo listsDan McGee1-3/+3
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-28Mark the todolists' flag view as never_cacheEvangelos Foutras1-2/+1
Also remove the @vary_on_headers('X-Requested-With') since it's irrelevant now. Dan: remove now unnecessary import. Signed-off-by: Evangelos Foutras <foutrelis@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-25Mark a few more pages as never cacheDan McGee1-0/+2
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-22Add 'never_cache' decorator in a bunch of placesDan McGee1-0/+4
Now that we cache everything, we need to ensure anyone doing edits and such gets the live data and not some cached version that was already updated and is now stale. Add the never_cache decorator to any of the CUD screens as well as a few others that might benefit from always being regenerated. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-08Use Sites framework instead of hardcoded domain nameDan McGee1-1/+1
Instead of putting 'www.archlinux.org' all over the place, use the Django sites framework to pull the site name out of the database. Now these amazing things will work if you are running locally and decide to change the site! Signed-off-by: Dan McGee <dan@archlinux.org>
2010-06-02Rename todolist email templateDan McGee1-1/+1
More in line with our other templates that have .txt extensions. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-05-21Fix undefined variable issueDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-04-03Fix package URL in todo list emailsDan McGee1-1/+1
Fixes FS#18935. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-03-30Fix todolist dealing with package maintainersDan McGee1-3/+3
Forgot to update this, whoops. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-03-06Use repo.testing flag instead of test-based checksDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-03-02Unify spelling of 'Todo'Dan McGee1-3/+3
We used 'Todo', 'ToDo', and 'To-do' in different places. Unify them all to the first. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-02-27Ensure our cache is correct with AJAX requestsDan McGee1-0/+2
Since the same URLs serve two different responses based on the request being AJAX or not, we want to ensure we don't cache the wrong one and serve it up incorrectly. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-02-27Implement AJAX flagging for todo itemsEvangelos Foutras1-6/+11
[Some trailing whitespace got killed in the process. :3] Dan: I made a few small changes including moving the jQuery include down above the other script block; since it is not needed right away it can be loaded later in the page. Signed-off-by: Evangelos Foutras <foutrelis@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2010-02-10Remove archweb prefix from all importsDan McGee1-1/+1
Unnecessary, and lets us standardize on not using it everywhere. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-01-31Use select_related() to make a few more places more performantDan McGee1-1/+1
Especially when looking at packages, we always want the arch and repo. Another big hunk of changes deals with the very inefficient signoffs code. Signed-off-by: Dan McGee <dan@archlinux.org>
2010-01-31Adjust models and views for nullable maintainerEvangelos Foutras1-1/+1
Signed-off-by: Evangelos Foutras <foutrelis@gmail.com> [Dan: made a few other small touchups] Signed-off-by: Dan McGee <dan@archlinux.org>
2010-01-30Exclude repos ending with "Testing" from ToDosEvangelos Foutras1-1/+2
This should fix the issue with Community-Testing packages appearing in ToDo lists. After this change has been applied, simply edit and save a ToDo list to make its Community-Testing packages go away. Signed-off-by: Dan McGee <dan@archlinux.org>
2009-11-10added login_required to protect todolists viewsIsmael Carnales1-1/+4
2009-11-10fixed error in todolists list viewIsmael Carnales1-2/+2
2009-11-10modified import paths from archweb_dev to archwebIsmael Carnales1-1/+1
2008-10-12drop some print statementsDusty Phillips1-3/+1
2008-10-11use RequestContext because its standardDusty Phillips1-9/+9
2008-10-11port to django 1.0Dusty Phillips1-12/+14
2008-10-06drop a bunch of unusued importsDusty Phillips1-1/+1