summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz@archlinux.org>2018-05-10 23:17:05 +0200
committerLukas Fleischer <lfleischer@archlinux.org>2018-05-11 11:23:52 +0200
commit0ffa0679d214016511d07509774fcab5f3c56687 (patch)
tree0ec13781abd87251e1e994dd9343165146244221
parentce93360257f3b4ef60035a75708148fc814811c1 (diff)
downloadaur-0ffa0679d214016511d07509774fcab5f3c56687.tar.gz
aur-0ffa0679d214016511d07509774fcab5f3c56687.tar.xz
Use a link to accept orphan requests
Currently, a form is used instead of a link. This forwards to a confirmation page, and currently drops the "via" parameter in the process. As a result, accepted orphan requests usually show: Request #XXXXXX has been accepted automatically by the Arch User Repository package request system: The user YYYYYYY disowned the package. This is wrong, and should show (will show, if you manually add it or use the close button instead of the accept button): Request #XXXXXX has been rejected by YYYYYYY [1]: Fixes FS#56606. Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
-rw-r--r--web/template/pkgreq_results.php6
1 files changed, 1 insertions, 5 deletions
diff --git a/web/template/pkgreq_results.php b/web/template/pkgreq_results.php
index fb49dfae..3c824c0d 100644
--- a/web/template/pkgreq_results.php
+++ b/web/template/pkgreq_results.php
@@ -82,11 +82,7 @@
<a href="<?= get_pkgbase_uri($row['Name']) ?>merge/?into=<?= urlencode($row['MergeInto']) ?>&via=<?= intval($row['ID']) ?>"><?= __('Accept') ?></a>
<br />
<?php elseif ($row['Type'] == 'orphan' && $due): ?>
- <form action="<?= get_pkgbase_uri($row['Name']) . 'disown/'; ?>" method="post">
- <input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" />
- <input type="hidden" name="via" value="<?= intval($row['ID']) ?>" />
- <input type="submit" class="button text-button" name="do_Disown" value="<?= __('Accept') ?>" />
- </form>
+ <a href="<?= get_pkgbase_uri($row['Name']) ?>disown/?via=<?= intval($row['ID']) ?>"><?= __('Accept') ?></a>
<?php elseif ($row['Type'] == 'orphan' && !$due): ?>
<?= __('Locked') ?> (<?= $time_left_fmt ?>)
<br />