diff options
| author | Lukas Fleischer <archlinux@cryptocrack.de> | 2012-02-19 04:10:12 +0100 |
|---|---|---|
| committer | Lukas Fleischer <archlinux@cryptocrack.de> | 2012-02-19 04:48:31 +0100 |
| commit | 6f6904db3fa4921abc92b936dbc50bfdea0cb225 (patch) | |
| tree | d1d0fe4126c7fb64eda3095bf2b8b10be0b80343 | |
| parent | e53b91fe52be262d94a45769814c1e87c796988b (diff) | |
| download | aur-6f6904db3fa4921abc92b936dbc50bfdea0cb225.tar.gz aur-6f6904db3fa4921abc92b936dbc50bfdea0cb225.tar.xz | |
Fix some more XSS vulnerabilities
Escape strings properly using htmlspecialchars(). Seems like we missed
these in former cleanups. Fixes FS#28515.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
| -rw-r--r-- | web/template/header.php | 2 | ||||
| -rw-r--r-- | web/template/pkg_details.php | 2 | ||||
| -rw-r--r-- | web/template/stats/updates_table.php | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/web/template/header.php b/web/template/header.php index 8313bb36..578fcb9a 100644 --- a/web/template/header.php +++ b/web/template/header.php @@ -4,7 +4,7 @@ <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php print "$LANG\" lang=\"$LANG"; ?>"> <head> - <title>AUR (<?php print $LANG; ?>)<?php if ($title != "") { print " - " . $title; } ?></title> + <title>AUR (<?php print htmlspecialchars($LANG); ?>)<?php if ($title != "") { print " - " . htmlspecialchars($title); } ?></title> <link rel='stylesheet' type='text/css' href='css/fonts.css' /> <link rel='stylesheet' type='text/css' href='css/containers.css' /> <link rel='stylesheet' type='text/css' href='css/arch.css' /> diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index 880a6758..046f836b 100644 --- a/web/template/pkg_details.php +++ b/web/template/pkg_details.php @@ -69,7 +69,7 @@ $out_of_date_time = ($row["OutOfDateTS"] == 0) ? $msg : gmdate("r", intval($row[ <p> <span class='f2'><?php echo htmlspecialchars($row['Name']) . ' ' . htmlspecialchars($row['Version']) ?></span><br /> - <span class='f3'><a href="<?php echo htmlspecialchars($row['URL'], ENT_QUOTES) . '">' . $row['URL'] ?></a></span><br /> + <span class='f3'><a href="<?php echo htmlspecialchars($row['URL'], ENT_QUOTES) . '">' . htmlspecialchars($row['URL']) ?></a></span><br /> <span class='f3'><?php echo htmlspecialchars($row['Description'], ENT_QUOTES); ?></span> </p> diff --git a/web/template/stats/updates_table.php b/web/template/stats/updates_table.php index a8cdf5aa..8da67320 100644 --- a/web/template/stats/updates_table.php +++ b/web/template/stats/updates_table.php @@ -11,7 +11,7 @@ <td class="boxSoft"> <span class="f4"><span class="blue"> <a href="packages.php?ID=<?php print intval($row["ID"]); ?>"> -<?php print $row["Name"] . ' ' . $row["Version"]; ?> +<?php print htmlspecialchars($row["Name"]) . ' ' . htmlspecialchars($row["Version"]); ?> </a></span></span> </td> <td class="boxSoft"> |