summaryrefslogtreecommitdiffstats
path: root/aurweb/routers/sso.py
diff options
context:
space:
mode:
authorFrédéric Mangano-Tarumi <fmang@mg0.fr>2020-07-29 13:46:10 +0200
committerLukas Fleischer <lfleischer@archlinux.org>2021-02-20 17:25:19 +0100
commit87815d37c078c315ac3254741973cfba2bfccace (patch)
treec173ff4034ed7e462cd1d74eae84d76abc9950f2 /aurweb/routers/sso.py
parentbe31675b6589e66c8b10a64b44591b594d2eb735 (diff)
downloadaur-87815d37c078c315ac3254741973cfba2bfccace.tar.gz
aur-87815d37c078c315ac3254741973cfba2bfccace.tar.xz
Remove the per-user session limit
This feature was originally introduced by f961ffd9c7f2d3d51d3e3b060990a4fef9e56c1b as a fix for FS#12898 <https://bugs.archlinux.org/task/12898>. As of today, it is broken because of the `q.SessionID IS NULL` condition in the WHERE clause, which can’t be true because SessionID is not nullable. As a consequence, the session limit was not applied. The fact the absence of the session limit hasn’t caused any issue so far, and hadn’t even been noticed, suggests the feature is unneeded. Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
Diffstat (limited to 'aurweb/routers/sso.py')
-rw-r--r--aurweb/routers/sso.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/aurweb/routers/sso.py b/aurweb/routers/sso.py
index 2e4fbacc..73c884a4 100644
--- a/aurweb/routers/sso.py
+++ b/aurweb/routers/sso.py
@@ -56,7 +56,7 @@ def open_session(request, conn, user_id):
raise HTTPException(status_code=403, detail=_('Account suspended'))
# TODO This is a terrible message because it could imply the attempt at
# logging in just caused the suspension.
- # TODO apply [options] max_sessions_per_user
+
sid = uuid.uuid4().hex
conn.execute(Sessions.insert().values(
UsersID=user_id,