summaryrefslogtreecommitdiffstats
path: root/web/lib/acctfuncs.inc.php
diff options
context:
space:
mode:
authorFrédéric Mangano-Tarumi <fmang@mg0.fr>2020-07-27 14:44:03 +0200
committerLukas Fleischer <lfleischer@archlinux.org>2021-02-20 17:24:30 +0100
commit9290eee1385b4ac9e09fec4a784868789ea5a15d (patch)
tree8bb9a7e9b715b21f0edaa8cc942731bb77434868 /web/lib/acctfuncs.inc.php
parenta1a742b518b7ead1ea32b13dd52d5ea5248e8bb5 (diff)
downloadaur-9290eee1385b4ac9e09fec4a784868789ea5a15d.tar.gz
aur-9290eee1385b4ac9e09fec4a784868789ea5a15d.tar.xz
Stop redirecting stderr with proc_open
Error outputs were piped to a temporary buffer that wasn’t read by anyone, making debugging hard because errors were completely silenced. By not explicitly redirecting stderr on proc_open, the subprocess inherits its parent stderr. Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
Diffstat (limited to 'web/lib/acctfuncs.inc.php')
-rw-r--r--web/lib/acctfuncs.inc.php2
1 files changed, 0 insertions, 2 deletions
diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index 752abe97..b3822eaf 100644
--- a/web/lib/acctfuncs.inc.php
+++ b/web/lib/acctfuncs.inc.php
@@ -1347,7 +1347,6 @@ function notify($params) {
$descspec = array(
0 => array('pipe', 'r'),
1 => array('pipe', 'w'),
- 2 => array('pipe', 'w')
);
$p = proc_open($cmd, $descspec, $pipes);
@@ -1358,7 +1357,6 @@ function notify($params) {
fclose($pipes[0]);
fclose($pipes[1]);
- fclose($pipes[2]);
return proc_close($p);
}