diff options
| author | canyonknight <canyonknight@gmail.com> | 2012-06-23 20:40:11 +0200 |
|---|---|---|
| committer | Lukas Fleischer <archlinux@cryptocrack.de> | 2012-06-24 10:59:23 +0200 |
| commit | 2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b (patch) | |
| tree | dc5fd78a8cb46cd1475b45eeaa6544fbdeb23280 /web/lib/acctfuncs.inc.php | |
| parent | bfb25807c49d3f35cdce91947a442455e1940392 (diff) | |
| download | aur-2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b.tar.gz aur-2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b.tar.xz | |
Implement token system to fix CSRF vulnerabilities
Specially crafted pages can force authenticated users to unknowingly perform
actions on the AUR website despite being on an attacker's website. This
cross-site request forgery (CSRF) vulnerability applies to all POST data on
the AUR.
Implement a token system using a double submit cookie. Have a hidden form
value on every page containing POST forms. Use the newly added check_token() to
verify the token sent via POST matches the "AURSID" cookie value. Random
nature of the token limits potential for CSRF.
Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Diffstat (limited to 'web/lib/acctfuncs.inc.php')
| -rw-r--r-- | web/lib/acctfuncs.inc.php | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index 9bd6e511..51078b8f 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -33,6 +33,7 @@ function display_account_form($UTYPE,$A,$U="",$T="",$S="", print "<input type='hidden' name='Action' value='".$A."' />\n"; if ($UID) { print "<input type='hidden' name='ID' value='".$UID."' />\n"; + print "<input type='hidden' name='token' value='".htmlspecialchars($_COOKIE['AURSID'])."' />\n"; } print "</fieldset>"; print "<table border='0' cellpadding='0' cellspacing='0' width='80%' style=\"margin:0 auto;\">\n"; |