diff options
| author | canyonknight <canyonknight@gmail.com> | 2012-06-23 20:40:11 +0200 |
|---|---|---|
| committer | Lukas Fleischer <archlinux@cryptocrack.de> | 2012-06-24 10:59:23 +0200 |
| commit | 2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b (patch) | |
| tree | dc5fd78a8cb46cd1475b45eeaa6544fbdeb23280 /web/template/pkg_details.php | |
| parent | bfb25807c49d3f35cdce91947a442455e1940392 (diff) | |
| download | aur-2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b.tar.gz aur-2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b.tar.xz | |
Implement token system to fix CSRF vulnerabilities
Specially crafted pages can force authenticated users to unknowingly perform
actions on the AUR website despite being on an attacker's website. This
cross-site request forgery (CSRF) vulnerability applies to all POST data on
the AUR.
Implement a token system using a double submit cookie. Have a hidden form
value on every page containing POST forms. Use the newly added check_token() to
verify the token sent via POST matches the "AURSID" cookie value. Random
nature of the token limits potential for CSRF.
Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Diffstat (limited to 'web/template/pkg_details.php')
| -rw-r--r-- | web/template/pkg_details.php | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index 046f836b..193af848 100644 --- a/web/template/pkg_details.php +++ b/web/template/pkg_details.php @@ -10,6 +10,9 @@ if ($uid == $row["MaintainerUID"] or $edit_cat = "<form method='post' action='packages.php?ID=".$pkgid."'>\n"; $edit_cat.= "<p>"; $edit_cat.= "<input type='hidden' name='action' value='do_ChangeCategory' />"; + if ($SID) { + $edit_cat.= "<input type='hidden' name='token' value='".htmlspecialchars($_COOKIE['AURSID'])."' />"; + } $edit_cat.= "<span class='f3'>" . __("Category") . ":</span> "; $edit_cat.= "<select name='category_id'>\n"; foreach ($catarr as $cid => $catname) { |