From ee4b398033da18a0cc2c57b0b2994ca16290a99e Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Mon, 15 Aug 2011 10:12:17 +0200 Subject: Use "%s" instead of "%h" in format strings Use the standard string type specifier instead of "%h" in format strings. Both specifiers are treated equally in __() so we shouldn't break anything here. This also allows us to replace the hacky substitution algorithm in __() by vsprintf(). Signed-off-by: Lukas Fleischer --- web/html/index.php | 4 ++-- web/html/passreset.php | 2 +- web/html/pkgsubmit.php | 2 +- web/lib/acctfuncs.inc.php | 12 ++++++------ 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/web/html/index.php b/web/html/index.php index ffc5f008..138541f2 100644 --- a/web/html/index.php +++ b/web/html/index.php @@ -25,7 +25,7 @@ $dbh = db_connect(); ', '', '', @@ -37,7 +37,7 @@ echo __( ', '', '', '' diff --git a/web/html/passreset.php b/web/html/passreset.php index ed5d4d31..01f32047 100644 --- a/web/html/passreset.php +++ b/web/html/passreset.php @@ -122,7 +122,7 @@ html_header(__("Password Reset")); -

', ''); ?>

diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 64281c7a..a5cc0c05 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -273,7 +273,7 @@ if ($uid): $error = __( "Could not create directory %s.", $incoming_pkgdir); } } else { - $error = __( "You are not allowed to overwrite the %h%s%h package.", "", $pkg_name, ""); + $error = __( "You are not allowed to overwrite the %s%s%s package.", "", $pkg_name, ""); } if (!$error) { diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index 97fb69b9..59fa730f 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -233,7 +233,7 @@ function process_account_form($UTYPE,$TYPE,$A,$U="",$T="",$S="",$E="", if ($result) { $row = mysql_fetch_array($result); if ($row[0]) { - $error = __("The username, %h%s%h, is already in use.", + $error = __("The username, %s%s%s, is already in use.", "", htmlspecialchars($U,ENT_QUOTES), ""); } } @@ -251,7 +251,7 @@ function process_account_form($UTYPE,$TYPE,$A,$U="",$T="",$S="",$E="", if ($result) { $row = mysql_fetch_array($result); if ($row[0]) { - $error = __("The address, %h%s%h, is already in use.", + $error = __("The address, %s%s%s, is already in use.", "", htmlspecialchars($E,ENT_QUOTES), ""); } } @@ -273,12 +273,12 @@ function process_account_form($UTYPE,$TYPE,$A,$U="",$T="",$S="",$E="", "VALUES (1, 0, '" . implode("', '", $escaped) . "')"; $result = db_query($q, $dbh); if (!$result) { - print __("Error trying to create account, %h%s%h: %s.", + print __("Error trying to create account, %s%s%s: %s.", "", htmlspecialchars($U,ENT_QUOTES), "", mysql_error($dbh)); } else { # account created/modified, tell them so. # - print __("The account, %h%s%h, has been successfully created.", + print __("The account, %s%s%s, has been successfully created.", "", htmlspecialchars($U,ENT_QUOTES), ""); print "

\n"; print __("Click on the Home link above to login."); @@ -310,10 +310,10 @@ function process_account_form($UTYPE,$TYPE,$A,$U="",$T="",$S="",$E="", $q.= " WHERE ID = ".intval($UID); $result = db_query($q, $dbh); if (!$result) { - print __("Error trying to modify account, %h%s%h: %s.", + print __("Error trying to modify account, %s%s%s: %s.", "", htmlspecialchars($U,ENT_QUOTES), "", mysql_error($dbh)); } else { - print __("The account, %h%s%h, has been successfully modified.", + print __("The account, %s%s%s, has been successfully modified.", "", htmlspecialchars($U,ENT_QUOTES), ""); } } -- cgit v1.2.3-24-g4f1b