From 2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b Mon Sep 17 00:00:00 2001 From: canyonknight Date: Sat, 23 Jun 2012 14:40:11 -0400 Subject: Implement token system to fix CSRF vulnerabilities Specially crafted pages can force authenticated users to unknowingly perform actions on the AUR website despite being on an attacker's website. This cross-site request forgery (CSRF) vulnerability applies to all POST data on the AUR. Implement a token system using a double submit cookie. Have a hidden form value on every page containing POST forms. Use the newly added check_token() to verify the token sent via POST matches the "AURSID" cookie value. Random nature of the token limits potential for CSRF. Signed-off-by: canyonknight Signed-off-by: Lukas Fleischer --- web/html/account.php | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'web/html/account.php') diff --git a/web/html/account.php b/web/html/account.php index 387fd938..5a0ef50d 100644 --- a/web/html/account.php +++ b/web/html/account.php @@ -88,11 +88,13 @@ if (isset($_COOKIE["AURSID"])) { } elseif ($action == "UpdateAccount") { # user is submitting their modifications to an existing account # - process_account_form($atype, "edit", "UpdateAccount", - in_request("U"), in_request("T"), in_request("S"), - in_request("E"), in_request("P"), in_request("C"), - in_request("R"), in_request("L"), in_request("I"), - in_request("ID")); + if (check_token()) { + process_account_form($atype, "edit", "UpdateAccount", + in_request("U"), in_request("T"), in_request("S"), + in_request("E"), in_request("P"), in_request("C"), + in_request("R"), in_request("L"), in_request("I"), + in_request("ID")); + } } else { -- cgit v1.2.3-24-g4f1b