From 2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b Mon Sep 17 00:00:00 2001
From: canyonknight <canyonknight@gmail.com>
Date: Sat, 23 Jun 2012 14:40:11 -0400
Subject: Implement token system to fix CSRF vulnerabilities

Specially crafted pages can force authenticated users to unknowingly perform
actions on the AUR website despite being on an attacker's website. This
cross-site request forgery (CSRF) vulnerability applies to all POST data on
the AUR.

Implement a token system using a double submit cookie. Have a hidden form
value on every page containing POST forms. Use the newly added check_token() to
verify the token sent via POST matches the "AURSID" cookie value. Random
nature of the token limits potential for CSRF.

Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
---
 web/template/tu_details.php | 1 +
 1 file changed, 1 insertion(+)

(limited to 'web/template/tu_details.php')

diff --git a/web/template/tu_details.php b/web/template/tu_details.php
index 7d6c305d..dde53a8c 100644
--- a/web/template/tu_details.php
+++ b/web/template/tu_details.php
@@ -70,6 +70,7 @@ if (!$isrunning) { ?>
 <input type='submit' class='button' name='voteNo' value='<?php print __("No") ?>' />
 <input type='submit' class='button' name='voteAbstain' value='<?php print __("Abstain") ?>' />
 <input type='hidden' name='doVote' value='1' />
+<input type='hidden' name='token' value='<?php print htmlspecialchars($_COOKIE['AURSID']) ?>' />
 </fieldset>
 </form>
 <?php } else { ?>
-- 
cgit v1.2.3-24-g4f1b