summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2008-02-13 04:13:07 +0100
committerlpsolit%gmail.com <>2008-02-13 04:13:07 +0100
commitbc040aab7fd89c27cfb396f0577b9b757ea05312 (patch)
treebe32396b29f2af93f8988ff07e86470c9d7e4c57
parent30c7fa92ac2d0c76443fcc47907487a9ff0186b2 (diff)
downloadbugzilla-bc040aab7fd89c27cfb396f0577b9b757ea05312.tar.gz
bugzilla-bc040aab7fd89c27cfb396f0577b9b757ea05312.tar.xz
Bug 416481: No bugmail is sent if no comment is added on bug creation - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
-rwxr-xr-xBugzilla/Bug.pm8
-rw-r--r--Bugzilla/BugMail.pm2
2 files changed, 1 insertions, 9 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 9be3830cf..5cbe8a619 100755
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -1005,14 +1005,6 @@ sub _check_comment {
$comment =~ s/\r\n?/\n/g; # Get rid of \r.
ThrowUserError('comment_too_long') if length($comment) > MAX_COMMENT_LENGTH;
-
- # Creation-only checks
- if (!ref $invocant) {
- # On creation only, there must be a single-space comment, or
- # email will be supressed.
- $comment = ' ' if $comment eq '';
- }
-
return $comment;
}
diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm
index 13f25b5b4..2f132e2de 100644
--- a/Bugzilla/BugMail.pm
+++ b/Bugzilla/BugMail.pm
@@ -605,7 +605,7 @@ sub sendMail {
}
}
- if ($difftext eq "" && $newcomments eq "") {
+ if ($difftext eq "" && $newcomments eq "" && !$isnew) {
# Whoops, no differences!
return 0;
}