summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2008-01-20 09:45:31 +0100
committerlpsolit%gmail.com <>2008-01-20 09:45:31 +0100
commite49a811b3d40b3defc995d98a58ce3c593c00186 (patch)
tree25602fca6d99d55c87020c69a3a6835c2068dd1a
parenteacc9757e5f0517cc270223cd653ecbcf207855e (diff)
downloadbugzilla-e49a811b3d40b3defc995d98a58ce3c593c00186.tar.gz
bugzilla-e49a811b3d40b3defc995d98a58ce3c593c00186.tar.xz
Bug 143313: check_can_change_field() is no longer called with --do_not_change-- as field value - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
-rwxr-xr-xBugzilla/Bug.pm4
1 files changed, 1 insertions, 3 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 9f4433263..722914c5f 100755
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -3211,11 +3211,10 @@ sub CheckIfVotedConfirmed {
# $oldvalue - what they are changing it from
# $newvalue - what they are changing it to
# $PrivilegesRequired - return the reason of the failure, if any
-# $data - hash containing relevant parameters, e.g. from the CGI object
################################################################################
sub check_can_change_field {
my $self = shift;
- my ($field, $oldvalue, $newvalue, $PrivilegesRequired, $data) = (@_);
+ my ($field, $oldvalue, $newvalue, $PrivilegesRequired) = (@_);
my $user = Bugzilla->user;
$oldvalue = defined($oldvalue) ? $oldvalue : '';
@@ -3231,7 +3230,6 @@ sub check_can_change_field {
return 1;
# numeric fields need to be compared using ==
} elsif (($field eq 'estimated_time' || $field eq 'remaining_time')
- && (!$data || $newvalue ne $data->{'dontchange'})
&& $oldvalue == $newvalue)
{
return 1;