Bug 320727: Incorrect footer if no query is passed to buglist.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave

1 files changed, 5 insertions, 3 deletions

diff --git a/buglist.cgi b/buglist.cgi
index fb72cc790..079a8b7b4 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -60,6 +60,11 @@ my $template = Bugzilla->template;
 my $vars = {};
 my $buffer = $cgi->query_string();
 
+# We have to check the login here to get the correct footer if an error is
+# thrown and to prevent a logged out user to use QuickSearch if 'requirelogin'
+# is turned 'on'.
+Bugzilla->login();
+
 if (length($buffer) == 0) {
     print $cgi->header(-refresh=> '10; URL=query.cgi');
     ThrowUserError("buglist_parameters_required");
@@ -90,9 +95,6 @@ if ($dotweak) {
                                          object => "multiple_bugs"});
     GetVersionTable();
 }
-else {
-    Bugzilla->login();
-}
 
 # Hack to support legacy applications that think the RDF ctype is at format=rdf.
 if (defined $cgi->param('format') && $cgi->param('format') eq "rdf"