summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorByron Jones <bjones@mozilla.com>2014-01-28 07:15:01 +0100
committerByron Jones <bjones@mozilla.com>2014-01-28 07:15:01 +0100
commit19282ec337a17cb4edeed7fc6eb02def285b2394 (patch)
treeb2165d39623d9c8e0fb6adb56009d0c37506abf0
parentb7f003eb513877c6c19efd2f275e2ef5a918313e (diff)
downloadbugzilla-19282ec337a17cb4edeed7fc6eb02def285b2394.tar.gz
bugzilla-19282ec337a17cb4edeed7fc6eb02def285b2394.tar.xz
Bug 76498: QuickSearch: support comparison operators other than substring
-rw-r--r--Bugzilla/Search/Quicksearch.pm20
-rw-r--r--template/en/default/pages/quicksearch.html.tmpl46
2 files changed, 63 insertions, 3 deletions
diff --git a/Bugzilla/Search/Quicksearch.pm b/Bugzilla/Search/Quicksearch.pm
index 9c252d04f..6f0f8c939 100644
--- a/Bugzilla/Search/Quicksearch.pm
+++ b/Bugzilla/Search/Quicksearch.pm
@@ -116,6 +116,17 @@ use constant FIELD_OPERATOR => {
owner_idle_time => 'greaterthan',
};
+# Mappings for operators symbols to support operators other than "substring"
+use constant OPERATOR_SYMBOLS => {
+ ':' => 'substring',
+ '=' => 'equals',
+ '!=' => 'notequals',
+ '>=' => 'greaterthaneq',
+ '<=' => 'lessthaneq',
+ '>' => 'greaterthan',
+ '<' => 'lessthan',
+};
+
# We might want to put this into localconfig or somewhere
use constant PRODUCT_EXCEPTIONS => (
'row', # [Browser]
@@ -425,8 +436,9 @@ sub _handle_field_names {
# Generic field1,field2,field3:value1,value2 notation.
# We have to correctly ignore commas and colons in quotes.
- my @field_values = _parse_line(':', 1, $or_operand);
- if (scalar @field_values == 2) {
+ foreach my $symbol (keys %{ OPERATOR_SYMBOLS() }) {
+ my @field_values = _parse_line($symbol, 1, $or_operand);
+ next unless scalar @field_values == 2;
my @fields = _parse_line(',', 1, $field_values[0]);
my @values = _parse_line(',', 1, $field_values[1]);
foreach my $field (@fields) {
@@ -446,7 +458,9 @@ sub _handle_field_names {
}
foreach my $value (@values) {
next unless defined $value;
- my $operator = FIELD_OPERATOR->{$translated} || 'substring';
+ my $operator = FIELD_OPERATOR->{$translated}
+ || OPERATOR_SYMBOLS->{$symbol}
+ || 'substring';
# If the string was quoted to protect some special
# characters such as commas and colons, we need
# to remove quotes.
diff --git a/template/en/default/pages/quicksearch.html.tmpl b/template/en/default/pages/quicksearch.html.tmpl
index c43047d9f..18bf4dfb1 100644
--- a/template/en/default/pages/quicksearch.html.tmpl
+++ b/template/en/default/pages/quicksearch.html.tmpl
@@ -229,6 +229,52 @@
(<kbd>url</kbd> OR <kbd>location</kbd>) AND (<kbd>bar</kbd> OR
<kbd>field</kbd>) AND (NOT <kbd>focus</kbd>)</p>
</li>
+
+ <li>
+ The default operator, colon (:), performs a <strong>substring</strong>
+ match of the value. The following operators are supported:
+ <ul>
+ <li>
+ <strong>:</strong> (substring):<br>
+ <kbd><em>summary:foo</em></kbd> will search for [% terms.bugs %]
+ where the <kbd>summary</kbd> contains <kbd>foo</kbd>.
+ </li>
+ <li>
+ <strong>=</strong> (equals):<br>
+ <kbd><em>summary=foo</em></kbd> will search for [% terms.bugs %]
+ where the <kbd>summary</kbd> is exactly <kbd>foo</kbd>.
+ </li>
+ <li>
+ <strong>!=</strong> (notequals):<br>
+ <kbd><em>summary!=foo</em></kbd> will search for [% terms.bugs %]
+ where the <kbd>summary</kbd> is not <kbd>foo</kbd>.
+ </li>
+ <li>
+ <strong>&gt;</strong> (greaterthan):<br>
+ <kbd><em>creation_ts&gt;-2w</em></kbd> will search for [% terms.bugs %]
+ where that were created between two weeks ago and now, excluding [%
+ terms.bugs %] exactly two weeks old.
+ </li>
+ <li>
+ <strong>&gt;=</strong> (greaterthaneq):<br>
+ <kbd><em>creation_ts&gt;=-2w</em></kbd> will search for [% terms.bugs %]
+ where that were created between two weeks ago and now, including [%
+ terms.bugs %] exactly two weeks old.
+ </li>
+ <li>
+ <strong>&lt;</strong> (lessthan):<br>
+ <kbd><em>creation_ts&lt;-2w</em></kbd> will search for [% terms.bugs %]
+ where that were created more than two weeks ago, excluding [%
+ terms.bugs %] exactly two weeks old.
+ </li>
+ <li>
+ <strong>&lt;=</strong> (lessthaneq):<br>
+ <kbd><em>creation_ts&lt;=-2w</em></kbd> will search for [% terms.bugs %]
+ where that were created more than two weeks ago, including [%
+ terms.bugs %] exactly two weeks old.
+ </li>
+ </ul>
+ </li>
</ul>
<h2 id="shortcuts">Advanced Shortcuts</h2>