summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2011-08-16 03:44:09 +0200
committerFrédéric Buclin <LpSolit@gmail.com>2011-08-16 03:44:09 +0200
commit32ca131f3518873f80690b8bf51b32337c422927 (patch)
tree92f281f6cb22c86a03b29c1b089fc5b069a99fb1
parentf89f20583287fd49e54f4e0818f2d7ea46b58034 (diff)
downloadbugzilla-32ca131f3518873f80690b8bf51b32337c422927.tar.gz
bugzilla-32ca131f3518873f80690b8bf51b32337c422927.tar.xz
Bug 678772: version.pm 0.92 and newer forbids negative values, making checksetup.pl to fail
r/a=mkanat
-rw-r--r--Bugzilla/Install/Requirements.pm5
1 files changed, 3 insertions, 2 deletions
diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm
index 8825eb3a7..ef4bf3d22 100644
--- a/Bugzilla/Install/Requirements.pm
+++ b/Bugzilla/Install/Requirements.pm
@@ -717,8 +717,9 @@ sub _checking_for {
# show "ok" or "not found".
if (exists $params->{found}) {
my $found_string;
- # We do a string compare in case it's non-numeric.
- if ($found and $found eq "-1") {
+ # We do a string compare in case it's non-numeric. We make sure
+ # it's not a version object as negative versions are forbidden.
+ if ($found && !ref($found) && $found eq '-1') {
$found_string = install_string('module_not_found');
}
elsif ($found) {