summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjake%acutex.net <>2001-09-01 08:51:35 +0200
committerjake%acutex.net <>2001-09-01 08:51:35 +0200
commit415a5d128205e8d6b6749f962cf25c81316389f9 (patch)
treedaded32d7e210a99b91cc2609651d32d5184d854
parent21c2f341eda381ea88b32f48738869dca2e56253 (diff)
downloadbugzilla-415a5d128205e8d6b6749f962cf25c81316389f9.tar.gz
bugzilla-415a5d128205e8d6b6749f962cf25c81316389f9.tar.xz
Fix for bug 42810 - Bugzilla would choke if your product name contained a ' mark.
Patch by Christian Reis <kiko@async.com.br> r= justdave@syndicomm.com, caillon@returnzero.com
-rw-r--r--globals.pl2
-rwxr-xr-xquery.cgi2
2 files changed, 2 insertions, 2 deletions
diff --git a/globals.pl b/globals.pl
index dcfbce883..af3c26a3d 100644
--- a/globals.pl
+++ b/globals.pl
@@ -409,7 +409,7 @@ sub GenerateCode {
$result = "";
foreach my $k (sort { uc($a) cmp uc($b)} eval("keys $name")) {
$result .= GenerateCode("\$" . substr($name, 1) .
- "{'" . $k . "'}");
+ "{" . PerlQuote($k) . "}");
}
return $result;
} else {
diff --git a/query.cgi b/query.cgi
index 1013b7af0..10b644b63 100755
--- a/query.cgi
+++ b/query.cgi
@@ -347,7 +347,7 @@ sub make_js_array {
foreach my $p ( @prods ) {
# join each element with a "," case-insensitively alpha sorted
if ( $data{$p} ) {
- $ret .= $arr."['$p'] = [";
+ $ret .= $arr."[".SqlQuote($p)."] = [";
# the SqlQuote() protects our 's.
my @tmp = map( SqlQuote( $_ ), @{ $data{$p} } );
# do the join on a sorted, quoted list