diff options
| author | justdave%bugzilla.org <> | 2004-10-25 16:25:58 +0200 |
|---|---|---|
| committer | justdave%bugzilla.org <> | 2004-10-25 16:25:58 +0200 |
| commit | 53bd4df6f142c240d7beaa6b6789839da1f5f164 (patch) | |
| tree | b289d2cc6c469fb86b67461f76e0b88521a58643 | |
| parent | 23df77be557e495a78808769378ce1f29ac00b4f (diff) | |
| download | bugzilla-53bd4df6f142c240d7beaa6b6789839da1f5f164.tar.gz bugzilla-53bd4df6f142c240d7beaa6b6789839da1f5f164.tar.xz | |
[SECURITY] Bug 263780: Exporting a bug to XML exposes user comments and attachment summaries which are marked as private to users who are not members of the group allowed to see private comments and attachments. XML export is not exposed in the user interface, but is available to anyone who knows the correct URL to invoke it. This only affects sites that use the 'insidergroup' feature.
Patch by Joel Peshkin <bugreport@peshkin.net>
r=vladd,justdave, a=justdave
| -rwxr-xr-x | show_bug.cgi | 4 | ||||
| -rw-r--r-- | template/en/default/bug/show.xml.tmpl | 2 |
2 files changed, 6 insertions, 0 deletions
diff --git a/show_bug.cgi b/show_bug.cgi index 4803ff67b..03cf6f60d 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -113,6 +113,10 @@ if ($cgi->param("field")) { @fieldlist = $cgi->param("field"); } +unless (UserInGroup(Param("timetrackinggroup"))) { + @fieldlist = grep($_ !~ /_time$/, @fieldlist); +} + foreach (@fieldlist) { $displayfields{$_} = 1; } diff --git a/template/en/default/bug/show.xml.tmpl b/template/en/default/bug/show.xml.tmpl index 97d3dee67..37cead53d 100644 --- a/template/en/default/bug/show.xml.tmpl +++ b/template/en/default/bug/show.xml.tmpl @@ -53,6 +53,7 @@ [% IF displayfields.long_desc %] [% FOREACH c = bug.longdescs %] + [% NEXT IF c.isprivate && !UserInGroup(Param("insidergroup")) %] <long_desc> <who>[% c.email FILTER xml %]</who> <bug_when>[% c.time FILTER time FILTER xml %]</bug_when> @@ -63,6 +64,7 @@ [% IF displayfields.attachment %] [% FOREACH a = bug.attachments %] + [% NEXT IF a.isprivate && !UserInGroup(Param("insidergroup")) %] <attachment> <attachid>[% a.attachid %]</attachid> <date>[% a.date FILTER time FILTER xml %]</date> |