diff options
author | zach%zachlipton.com <> | 2002-01-28 03:59:38 +0100 |
---|---|---|
committer | zach%zachlipton.com <> | 2002-01-28 03:59:38 +0100 |
commit | 5bbb0f101966acb382e643303129a9057ff49987 (patch) | |
tree | 69c28e0c01025b0159e542a2417c209c1a5786b6 | |
parent | f87e6aed402ac77ad19a9d2b7e2f7b574bc048b8 (diff) | |
download | bugzilla-5bbb0f101966acb382e643303129a9057ff49987.tar.gz bugzilla-5bbb0f101966acb382e643303129a9057ff49987.tar.xz |
Fix for bug 121735: Perl warning running checksetup.pl if a module has a
non-numeric version number. Patch sets checksetup.pl to use a string
compare instead of a numeric one.
Patch by Dave Miller. r1=Bradley Baetz and r2=Gerv
-rwxr-xr-x | checksetup.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/checksetup.pl b/checksetup.pl index e5864921b..d793879ff 100755 --- a/checksetup.pl +++ b/checksetup.pl @@ -167,10 +167,10 @@ sub have_vers { $vnum = ${"${pkg}::VERSION"} || ${"${pkg}::Version"} || 0; $vnum = -1 if $@; - if ($vnum < 0) { + if ($vnum eq "-1") { # string compare just in case it's non-numeric $vstr = "not found"; } - elsif ($vnum > 0) { + elsif (vers_cmp($vnum,"0") > -1) { $vstr = "found v$vnum"; } else { |