diff options
| author | Max Kanat-Alexander <mkanat@bugzilla.org> | 2010-02-16 01:12:02 +0100 |
|---|---|---|
| committer | Max Kanat-Alexander <mkanat@bugzilla.org> | 2010-02-16 01:12:02 +0100 |
| commit | bcd2c583433d27295bff332398935252ddcc5b7a (patch) | |
| tree | efb2905e9c804d70d87c829137a1679c6a8c2544 | |
| parent | 013e70552d98fc3beb0d075108138a8b6afbacc7 (diff) | |
| download | bugzilla-bcd2c583433d27295bff332398935252ddcc5b7a.tar.gz bugzilla-bcd2c583433d27295bff332398935252ddcc5b7a.tar.xz | |
* Disable the Voting extension by default.
* There was a syntax error in the code-error-errors.html.tmpl hook in the
Voting extension.
* Creating the TestProduct during checksetup was throwing an warning
about use of an uninitialized value, due to the Voting extension.
https://bugzilla.mozilla.org/show_bug.cgi?id=372979
| -rw-r--r-- | extensions/Voting/Extension.pm | 2 | ||||
| -rw-r--r-- | extensions/Voting/disabled | 0 | ||||
| -rw-r--r-- | extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl | 1 |
3 files changed, 2 insertions, 1 deletions
diff --git a/extensions/Voting/Extension.pm b/extensions/Voting/Extension.pm index 6857135eb..47105bf98 100644 --- a/extensions/Voting/Extension.pm +++ b/extensions/Voting/Extension.pm @@ -326,7 +326,7 @@ sub _check_votestoconfirm { sub _check_votes { my ($default, $invocant, $votes, $field) = @_; - detaint_natural($votes); + detaint_natural($votes) if defined $votes; # On product creation, if the number of votes is not a valid integer, # we silently fall back to the given default value. # If the product already exists and the change is illegal, we complain. diff --git a/extensions/Voting/disabled b/extensions/Voting/disabled new file mode 100644 index 000000000..e69de29bb --- /dev/null +++ b/extensions/Voting/disabled diff --git a/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl b/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl index 719cbe4c1..50e915941 100644 --- a/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl +++ b/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl @@ -22,3 +22,4 @@ [% title = "$terms.Bug Cannot Be Confirmed" %] There is no valid transition from [%+ display_value("bug_status", "UNCONFIRMED") FILTER html %] to an open state +[% END %] |