summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDylan William Hardison <dylan@hardison.net>2018-03-12 21:44:16 +0100
committerGitHub <noreply@github.com>2018-03-12 21:44:16 +0100
commitb6ffa8dec3bd7b14f8096a60ad9740ccda92a044 (patch)
treece9856c6291f19b6b78118547a6e2727eac41ab8
parent34328982329c0b5091155f852c84f716c12f14d8 (diff)
downloadbugzilla-b6ffa8dec3bd7b14f8096a60ad9740ccda92a044.tar.gz
bugzilla-b6ffa8dec3bd7b14f8096a60ad9740ccda92a044.tar.xz
no bug - increase severity of several critic warnings so they're more visibile
-rw-r--r--.perlcriticrc20
1 files changed, 19 insertions, 1 deletions
diff --git a/.perlcriticrc b/.perlcriticrc
index 15ff6c82b..0c0d1c9be 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -3,10 +3,28 @@ severity = 1
[-CodeLayout::RequireTidyCode]
#perltidyrc = .perltidyrc
+#severity = 2
+
[InputOutput::RequireCheckedSyscalls]
+severity = 2
functions = :builtins
exclude_functions = print say sleep binmode
+[ValuesAndExpressions::ProhibitInterpolationOfLiterals]
+severity = 2
+
+[Freenode::EmptyReturn]
+severity = 2
+
+[CodeLayout::RequireTrailingCommas]
+severity = 2
+
+[CodeLayout::ProhibitParensWithBuiltins]
+severity = 2
+
+[RegularExpressions::ProhibitUnusualDelimiters]
+severity = 2
+
[-BuiltinFunctions::ProhibitUselessTopic]
[-ControlStructures::ProhibitCascadingIfElse]
[-ControlStructures::ProhibitPostfixControls]
@@ -46,7 +64,7 @@ exclude_functions = print say sleep binmode
# _build_* are allowed
[Subroutines::ProhibitUnusedPrivateSubroutines]
- private_name_regex = _(?!_|build_)\w+
+private_name_regex = _(?!_|build_)\w+
# I don't agree with this policy because
# a bare return can actually cause more problems.