diff options
| author | Dylan William Hardison <dylan@hardison.net> | 2018-05-14 05:57:12 +0200 |
|---|---|---|
| committer | Dylan William Hardison <dylan@hardison.net> | 2018-05-14 05:57:12 +0200 |
| commit | e1a952fd4b5828bf7fac787ecd217ce7c81b06c4 (patch) | |
| tree | f5c658f48c37a9e1ec315d782e90b50f577ba100 | |
| parent | e8f272c6f79dc8a919911d88a5b455bc67792f64 (diff) | |
| download | bugzilla-e1a952fd4b5828bf7fac787ecd217ce7c81b06c4.tar.gz bugzilla-e1a952fd4b5828bf7fac787ecd217ce7c81b06c4.tar.xz | |
fix bug in flagtype comments when there are no flag types
| -rw-r--r-- | extensions/FlagTypeComment/Extension.pm | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/extensions/FlagTypeComment/Extension.pm b/extensions/FlagTypeComment/Extension.pm index 3ec506176..e7b34113d 100644 --- a/extensions/FlagTypeComment/Extension.pm +++ b/extensions/FlagTypeComment/Extension.pm @@ -127,13 +127,18 @@ sub _set_ftc_states { 'active_or_has_flags' => $bug->id, }); - my $types = join(',', map { $_->id } @$flag_types); - my $states = "'" . join("','", FLAGTYPE_COMMENT_STATES) . "'"; - $db_result = $dbh->selectall_arrayref( - "SELECT type_id AS flagtype, on_status AS state, comment AS text - FROM flagtype_comments - WHERE type_id IN ($types) AND on_status IN ($states)", - { Slice => {} }); + if (@$flag_types) { + my $types = join(',', map { $_->id } @$flag_types); + my $states = "'" . join("','", FLAGTYPE_COMMENT_STATES) . "'"; + $db_result = $dbh->selectall_arrayref( + "SELECT type_id AS flagtype, on_status AS state, comment AS text + FROM flagtype_comments + WHERE type_id IN ($types) AND on_status IN ($states)", + { Slice => {} }); + } + else { + $db_result = []; + } } foreach my $row (@$db_result) { |