summaryrefslogtreecommitdiffstats
path: root/Bugzilla/Attachment.pm
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2011-10-01 13:22:13 +0200
committerFrédéric Buclin <LpSolit@gmail.com>2011-10-01 13:22:13 +0200
commit898e5ab5f292d8d0d72ae0aa9fc6d4638e5d6eca (patch)
tree12578cfd06ae792777e9ef93dc5b0a95d6d5fbfb /Bugzilla/Attachment.pm
parentf517974618ba835014e9d2a3565109af469f5d34 (diff)
downloadbugzilla-898e5ab5f292d8d0d72ae0aa9fc6d4638e5d6eca.tar.gz
bugzilla-898e5ab5f292d8d0d72ae0aa9fc6d4638e5d6eca.tar.xz
Bug 582529: Ambiguous error message "You did not specify a file to attach" when deleting an existing attachment filename
a=LpSolit
Diffstat (limited to 'Bugzilla/Attachment.pm')
-rw-r--r--Bugzilla/Attachment.pm9
1 files changed, 8 insertions, 1 deletions
diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm
index a39dc3af4..3a8e7d5d5 100644
--- a/Bugzilla/Attachment.pm
+++ b/Bugzilla/Attachment.pm
@@ -565,7 +565,14 @@ sub _check_filename {
my ($invocant, $filename) = @_;
$filename = clean_text($filename);
- $filename || ThrowUserError('file_not_specified');
+ if (!$filename) {
+ if (ref $invocant) {
+ ThrowUserError('filename_not_specified');
+ }
+ else {
+ ThrowUserError('file_not_specified');
+ }
+ }
# Remove path info (if any) from the file name. The browser should do this
# for us, but some are buggy. This may not work on Mac file names and could