summaryrefslogtreecommitdiffstats
path: root/Bugzilla/Bug.pm
diff options
context:
space:
mode:
authorByron Jones <glob@mozilla.com>2015-02-02 05:38:16 +0100
committerByron Jones <glob@mozilla.com>2015-02-02 05:38:16 +0100
commit1ccc683d4d94ea70e763fbd4af9721cb4bca1c0d (patch)
tree90ec8af17c49c130b0e817d2ef00c8c667dcb764 /Bugzilla/Bug.pm
parente62f3072492aa55e626325e8889365b23c25892f (diff)
downloadbugzilla-1ccc683d4d94ea70e763fbd4af9721cb4bca1c0d.tar.gz
bugzilla-1ccc683d4d94ea70e763fbd4af9721cb4bca1c0d.tar.xz
Bug 1123769: add a "rank" field to bugzilla to track priority
Diffstat (limited to 'Bugzilla/Bug.pm')
-rw-r--r--Bugzilla/Bug.pm25
1 files changed, 25 insertions, 0 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 7d47e9bb5..e1f533274 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -179,6 +179,9 @@ sub VALIDATORS {
elsif ($field->type == FIELD_TYPE_BUG_ID) {
$validator = \&_check_bugid_field;
}
+ elsif ($field->type == FIELD_TYPE_INTEGER) {
+ $validator = \&_check_integer_field;
+ }
else {
$validator = \&_check_default_field;
}
@@ -2251,6 +2254,28 @@ sub _check_bugid_field {
return $checked_id;
}
+sub _check_integer_field {
+ my ($invocant, $value, $field) = @_;
+ $value = defined($value) ? trim($value) : '';
+
+ # BMO - allow empty values
+ if ($value eq '') {
+ return undef;
+ }
+
+ my $orig_value = $value;
+ if (!detaint_signed($value)) {
+ ThrowUserError("number_not_integer",
+ {field => $field, num => $orig_value});
+ }
+ elsif ($value > MAX_INT_32) {
+ ThrowUserError("number_too_large",
+ {field => $field, num => $orig_value, max_num => MAX_INT_32});
+ }
+
+ return $value;
+}
+
sub _check_relationship_loop {
# Generates a dependency tree for a given bug. Calls itself recursively
# to generate sub-trees for the bug's dependencies.