diff options
| author | Dylan William Hardison <dylan@hardison.net> | 2018-10-01 18:03:41 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-10-01 18:03:41 +0200 |
| commit | dd5c0861db83e58ae7f507b4ecfc564d96792cb8 (patch) | |
| tree | 7c0f44689a0cd3c1c122342ba7861cb6c72e8e6e /Bugzilla/CGI.pm | |
| parent | 7e6845e954da409b07d9e8ccb8c1e1ea6df6cfde (diff) | |
| download | bugzilla-dd5c0861db83e58ae7f507b4ecfc564d96792cb8.tar.gz bugzilla-dd5c0861db83e58ae7f507b4ecfc564d96792cb8.tar.xz | |
Bug 1495071 - Mojolicious Cleanup
There are some things that should've been in the first patch but were missed:
1. Calling $c->finish in the finally block should not happen if an exception has
been raised.
2. Bugzilla->cleanup() should be called at the same time the mojolicious stash
is cleared.
3. Code referencing the shutdownhtml should be removed
4. The conditionals that ran code in Bugzilla.pm when it was not run under
mod_perl should instead check where the Bugzilla.pm module was loaded from.
5. Revert the default template from #770
6. Also removed some stuff that manipulates the PATH and signals, which we
shouldn't do
Diffstat (limited to 'Bugzilla/CGI.pm')
| -rw-r--r-- | Bugzilla/CGI.pm | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index e76b1c609..4be384b67 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -97,12 +97,6 @@ sub _init_bz_cgi_globals { # We need to disable output buffering - see bug 179174 $| = 1; - # Ignore SIGTERM and SIGPIPE - this prevents DB corruption. If the user closes - # their browser window while a script is running, the web server sends these - # signals, and we don't want to die half way through a write. - $SIG{TERM} = 'IGNORE'; - $SIG{PIPE} = 'IGNORE'; - # We don't precompile any functions here, that's done specially in # mod_perl code. $invocant->_setup_symbols(qw(:no_xhtml :oldstyle_urls :private_tempfiles |