diff options
| author | Byron Jones <glob@mozilla.com> | 2014-06-11 17:00:52 +0200 |
|---|---|---|
| committer | Byron Jones <glob@mozilla.com> | 2014-06-11 17:00:52 +0200 |
| commit | 8690811cafbac9f588faac26044f6d428354f811 (patch) | |
| tree | c8466abd9c12d0db63a91777aa96d721dfbec6e7 /Bugzilla/JobQueue.pm | |
| parent | 1a8d7747d93668b4189110712973515774de1c07 (diff) | |
| download | bugzilla-8690811cafbac9f588faac26044f6d428354f811.tar.gz bugzilla-8690811cafbac9f588faac26044f6d428354f811.tar.xz | |
Bug 962424: jobqueue's worker process should process messages in batches
Diffstat (limited to 'Bugzilla/JobQueue.pm')
| -rw-r--r-- | Bugzilla/JobQueue.pm | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/Bugzilla/JobQueue.pm b/Bugzilla/JobQueue.pm index a94598b87..669076dd5 100644 --- a/Bugzilla/JobQueue.pm +++ b/Bugzilla/JobQueue.pm @@ -43,6 +43,10 @@ use constant JOB_MAP => { # across requests. use constant DRIVER_CACHE_TIME => 300; # 5 minutes +# To avoid memory leak/fragmentation, a worker process won't process more than +# MAX_MESSAGES messages. +use constant MAX_MESSAGES => 1000; + sub job_map { if (!defined(Bugzilla->request_cache->{job_map})) { my $job_map = JOB_MAP; @@ -160,6 +164,16 @@ sub work_once { return $self->SUPER::work_once(@_); } +# Never process more than MAX_MESSAGES in one batch, to avoid memory +# leak/fragmentation issues. +sub work_until_done { + my $self = shift; + my $count = 0; + while ($count++ < MAX_MESSAGES) { + $self->work_once or last; + } +} + 1; __END__ |