diff options
| author | Dylan William Hardison <dylan@hardison.net> | 2018-07-31 19:54:12 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-31 19:54:12 +0200 |
| commit | e1b3729da40453f33a836eb75c8990cb4a42a634 (patch) | |
| tree | c052bbfee879693e1fb879976863d84d2ff9c88a /Bugzilla/User | |
| parent | d133f849672bdd7ad1b22e2ffc327fc65c2b95e8 (diff) | |
| download | bugzilla-e1b3729da40453f33a836eb75c8990cb4a42a634.tar.gz bugzilla-e1b3729da40453f33a836eb75c8990cb4a42a634.tar.xz | |
Bug 1320977 - performance tweaks
Diffstat (limited to 'Bugzilla/User')
| -rw-r--r-- | Bugzilla/User/Setting.pm | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/Bugzilla/User/Setting.pm b/Bugzilla/User/Setting.pm index a0b079ec7..ac53fbb32 100644 --- a/Bugzilla/User/Setting.pm +++ b/Bugzilla/User/Setting.pm @@ -13,8 +13,6 @@ use strict; use warnings; use base qw(Exporter); - - # Module stuff @Bugzilla::User::Setting::EXPORT = qw( get_all_settings @@ -25,6 +23,7 @@ use base qw(Exporter); use Bugzilla::Error; use Bugzilla::Util qw(trick_taint get_text); +use Module::Runtime qw(require_module); ############################### ### Module Initialization ### @@ -104,9 +103,8 @@ sub new { $self->{'category'} = shift; } if ($subclass) { - eval('require ' . $class . '::' . $subclass); - $@ && ThrowCodeError('setting_subclass_invalid', - {'subclass' => $subclass}); + eval { require_module( $class . '::' . $subclass ) } + || ThrowCodeError( 'setting_subclass_invalid', { 'subclass' => $subclass } ); $class = $class . '::' . $subclass; } bless($self, $class); |