diff options
author | David Lawrence <dkl@mozilla.com> | 2015-12-22 21:53:19 +0100 |
---|---|---|
committer | David Lawrence <dkl@mozilla.com> | 2015-12-22 21:53:19 +0100 |
commit | 8a1506c0ac3b9fa6539cc153eff0d291c645d1d5 (patch) | |
tree | d4f22925a8b9db01c41792d83a0bbf9450c78aee /Bugzilla/WebService/Util.pm | |
parent | 1e7b4002794930fad702718714b5d1c291bf816c (diff) | |
download | bugzilla-8a1506c0ac3b9fa6539cc153eff0d291c645d1d5.tar.gz bugzilla-8a1506c0ac3b9fa6539cc153eff0d291c645d1d5.tar.xz |
Revert "Bug 1234325 - Backport upstream bug 1230932 to bmo/4.2 to fix providing a condition as an ID to the webservice results in a taint error"
This reverts commit 1e7b4002794930fad702718714b5d1c291bf816c.
Diffstat (limited to 'Bugzilla/WebService/Util.pm')
-rw-r--r-- | Bugzilla/WebService/Util.pm | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/Bugzilla/WebService/Util.pm b/Bugzilla/WebService/Util.pm index e4c3eda44..4280f28e6 100644 --- a/Bugzilla/WebService/Util.pm +++ b/Bugzilla/WebService/Util.pm @@ -29,7 +29,6 @@ use Bugzilla::WebService::Constants; use Storable qw(dclone); use URI::Escape qw(uri_unescape); -use List::MoreUtils qw(all any); use base qw(Exporter); @@ -232,8 +231,7 @@ sub validate { # sent any parameters at all, and we're getting @keys where # $params should be. return ($self, undef) if (defined $params and !ref $params); - - my @id_params = qw( ids comment_ids ); + # If @keys is not empty then we convert any named # parameters that have scalar values to arrayrefs # that match. @@ -242,12 +240,6 @@ sub validate { $params->{$key} = ref $params->{$key} ? $params->{$key} : [ $params->{$key} ]; - - if (any { $key eq $_ } @id_params) { - my $ids = $params->{$key}; - ThrowCodeError('param_integer_array_required', { param => $key }) - unless ref($ids) eq 'ARRAY' && all { /^[0-9]+$/ } @$ids; - } } } |