diff options
| author | Frédéric Buclin <LpSolit@gmail.com> | 2011-09-29 01:25:47 +0200 |
|---|---|---|
| committer | Frédéric Buclin <LpSolit@gmail.com> | 2011-09-29 01:25:47 +0200 |
| commit | dd832b2728550c696a324d74a3a0013e87d8f5c8 (patch) | |
| tree | 0e0e704c1f7d21f4d65d8b11525d55daf95edf80 /Bugzilla | |
| parent | 36478e4ed9e8b3f1e613a0829e4ee9f54c1f8f40 (diff) | |
| download | bugzilla-dd832b2728550c696a324d74a3a0013e87d8f5c8.tar.gz bugzilla-dd832b2728550c696a324d74a3a0013e87d8f5c8.tar.xz | |
Bug 686786: Decreasing votestoconfirm in editproducts.cgi crashes Bugzilla
r/a=mkanat
Diffstat (limited to 'Bugzilla')
| -rw-r--r-- | Bugzilla/Object.pm | 2 | ||||
| -rw-r--r-- | Bugzilla/Product.pm | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/Bugzilla/Object.pm b/Bugzilla/Object.pm index 1cad3e829..29a6415b9 100644 --- a/Bugzilla/Object.pm +++ b/Bugzilla/Object.pm @@ -441,6 +441,8 @@ sub audit_log { # During update, it's the actual %changes hash produced by update(). foreach my $field (keys %$changes) { + # Skip private changes. + next if $field =~ /^_/; my ($from, $to) = @{ $changes->{$field} }; $sth->execute($user_id, $class, $self->id, $field, $from, $to); } diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm index 64a146be9..486d177c7 100644 --- a/Bugzilla/Product.pm +++ b/Bugzilla/Product.pm @@ -223,7 +223,7 @@ sub update { $new_setting->{group}->name, Bugzilla->user->id, $timestamp); } - push(@{$changes->{'group_controls'}->{'now_mandatory'}}, + push(@{$changes->{'_group_controls'}->{'now_mandatory'}}, {name => $new_setting->{group}->name, bug_count => scalar @$bug_ids}); } @@ -248,7 +248,7 @@ sub update { $old_setting->{group}->name, '', Bugzilla->user->id, $timestamp); } - push(@{$changes->{'group_controls'}->{'now_na'}}, + push(@{$changes->{'_group_controls'}->{'now_na'}}, {name => $old_setting->{group}->name, bug_count => scalar @$bug_ids}); } |