diff options
| author | Simon Green <sgreen+mozilla@redhat.com> | 2012-10-09 09:23:39 +0200 |
|---|---|---|
| committer | Byron Jones <bjones@mozilla.com> | 2012-10-09 09:23:39 +0200 |
| commit | f9e41025a332f57b3d9cabed8418e208fbd90400 (patch) | |
| tree | 468ab03286899ae9d77d856ece5768b6373cfa40 /Bugzilla | |
| parent | ab2667128b1c9546bd0d1df63af2e19d19b94e5f (diff) | |
| download | bugzilla-f9e41025a332f57b3d9cabed8418e208fbd90400.tar.gz bugzilla-f9e41025a332f57b3d9cabed8418e208fbd90400.tar.xz | |
Bug 753635: Allow editing local see also even if you cannot edit the other bug
r=glob, a=LpSolit
Diffstat (limited to 'Bugzilla')
| -rw-r--r-- | Bugzilla/Bug.pm | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 741475a74..686828015 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -2878,7 +2878,8 @@ sub add_see_also { # ref bug id for sending changes email. my $ref_bug = delete $field_values->{ref_bug}; if ($class->isa('Bugzilla::BugUrl::Bugzilla::Local') - and !$skip_recursion) + and !$skip_recursion + and $ref_bug->check_can_change_field('see_also', '', $self->id, \$privs)) { $ref_bug->add_see_also($self->id, 'skip_recursion'); push @{ $self->{_update_ref_bugs} }, $ref_bug; @@ -2910,12 +2911,15 @@ sub remove_see_also { # we need to notify changes for that bug too. $removed_bug_url = $removed_bug_url->[0]; if (!$skip_recursion and $removed_bug_url - and $removed_bug_url->isa('Bugzilla::BugUrl::Bugzilla::Local')) + and $removed_bug_url->isa('Bugzilla::BugUrl::Bugzilla::Local') + and $removed_bug_url->ref_bug_url) { my $ref_bug = Bugzilla::Bug->check($removed_bug_url->ref_bug_url->bug_id); - if (Bugzilla->user->can_edit_product($ref_bug->product_id)) { + if (Bugzilla->user->can_edit_product($ref_bug->product_id) + and $ref_bug->check_can_change_field('see_also', $self->id, '', \$privs)) + { my $self_url = $removed_bug_url->local_uri($self->id); $ref_bug->remove_see_also($self_url, 'skip_recursion'); push @{ $self->{_update_ref_bugs} }, $ref_bug; |