summaryrefslogtreecommitdiffstats
path: root/Bugzilla
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2011-09-29 01:27:24 +0200
committerFrédéric Buclin <LpSolit@gmail.com>2011-09-29 01:27:24 +0200
commitf517974618ba835014e9d2a3565109af469f5d34 (patch)
treee3b14688f85d7647edc745c5a81828f9d7bb933e /Bugzilla
parent02f040862148243081d016cb33161f9033bab95c (diff)
downloadbugzilla-f517974618ba835014e9d2a3565109af469f5d34.tar.gz
bugzilla-f517974618ba835014e9d2a3565109af469f5d34.tar.xz
Bug 686786: Decreasing votestoconfirm in editproducts.cgi crashes Bugzilla
r/a=mkanat
Diffstat (limited to 'Bugzilla')
-rw-r--r--Bugzilla/Object.pm2
-rw-r--r--Bugzilla/Product.pm4
2 files changed, 4 insertions, 2 deletions
diff --git a/Bugzilla/Object.pm b/Bugzilla/Object.pm
index 1cad3e829..29a6415b9 100644
--- a/Bugzilla/Object.pm
+++ b/Bugzilla/Object.pm
@@ -441,6 +441,8 @@ sub audit_log {
# During update, it's the actual %changes hash produced by update().
foreach my $field (keys %$changes) {
+ # Skip private changes.
+ next if $field =~ /^_/;
my ($from, $to) = @{ $changes->{$field} };
$sth->execute($user_id, $class, $self->id, $field, $from, $to);
}
diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm
index 85524ac47..a0079a033 100644
--- a/Bugzilla/Product.pm
+++ b/Bugzilla/Product.pm
@@ -223,7 +223,7 @@ sub update {
$new_setting->{group}->name,
Bugzilla->user->id, $timestamp);
}
- push(@{$changes->{'group_controls'}->{'now_mandatory'}},
+ push(@{$changes->{'_group_controls'}->{'now_mandatory'}},
{name => $new_setting->{group}->name,
bug_count => scalar @$bug_ids});
}
@@ -248,7 +248,7 @@ sub update {
$old_setting->{group}->name, '',
Bugzilla->user->id, $timestamp);
}
- push(@{$changes->{'group_controls'}->{'now_na'}},
+ push(@{$changes->{'_group_controls'}->{'now_na'}},
{name => $old_setting->{group}->name,
bug_count => scalar @$bug_ids});
}