diff options
author | Dylan William Hardison <dylan@hardison.net> | 2018-07-31 19:06:08 +0200 |
---|---|---|
committer | Dylan William Hardison <dylan@hardison.net> | 2018-07-31 19:06:08 +0200 |
commit | eec09d8bec17b7f11a5d204562c4646959696d97 (patch) | |
tree | b82fd1dd634014e29ae72e90682bf63e26cd90c1 /buglist.cgi | |
parent | a108778bc2784cdadfc6b2df4ec989b46dc162ca (diff) | |
download | bugzilla-eec09d8bec17b7f11a5d204562c4646959696d97.tar.gz bugzilla-eec09d8bec17b7f11a5d204562c4646959696d97.tar.xz |
review nits
Diffstat (limited to 'buglist.cgi')
-rwxr-xr-x | buglist.cgi | 42 |
1 files changed, 1 insertions, 41 deletions
diff --git a/buglist.cgi b/buglist.cgi index fee259a2b..019bf0d4e 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -105,27 +105,6 @@ my $agent = ($cgi->http('X-Moz') && $cgi->http('X-Moz') =~ /\bmicrosummary\b/); my $format = $template->get_format("list/list", scalar $cgi->param('format'), scalar $cgi->param('ctype')); -# Use server push to display a "Please wait..." message for the user while -# executing their query if their browser supports it and they are viewing -# the bug list as HTML and they have not disabled it by adding &serverpush=0 -# to the URL. -# -# Server push is a Netscape 3+ hack incompatible with MSIE, Lynx, and others. -# Even Communicator 4.51 has bugs with it, especially during page reload. -# http://www.browsercaps.org used as source of compatible browsers. -# Safari (WebKit) does not support it, despite a UA that says otherwise (bug 188712) -# MSIE 5+ supports it on Mac (but not on Windows) (bug 190370) -# -my $serverpush = 0; - # $format->{'extension'} eq "html" - # && exists $ENV{'HTTP_USER_AGENT'} - # && $ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/ - # && (($ENV{'HTTP_USER_AGENT'} !~ /[Cc]ompatible/) || ($ENV{'HTTP_USER_AGENT'} =~ /MSIE 5.*Mac_PowerPC/)) - # && $ENV{'HTTP_USER_AGENT'} !~ /(?:WebKit|Trident|KHTML)/ - # && !$agent - # && !defined($cgi->param('serverpush')) - # || $cgi->param('serverpush'); - my $order = $cgi->param('order') || ""; # The params object to use for the actual query itself @@ -746,18 +725,6 @@ $params->delete('limit') if $vars->{'default_limited'}; # Time to use server push to display an interim message to the user until # the query completes and we can display the bug list. -if ($serverpush) { - print $cgi->multipart_init(); - print $cgi->multipart_start(-type => 'text/html'); - - # Generate and return the UI (HTML page) from the appropriate template. - $template->process("list/server-push.html.tmpl", $vars) - || ThrowTemplateError($template->error()); - - # Don't do multipart_end() until we're ready to display the replacement - # page, otherwise any errors that happen before then (like SQL errors) - # will result in a blank page being shown to the user instead of the error. -} # Connect to the shadow database if this installation is using one to improve # query performance. @@ -1136,11 +1103,4 @@ $cgi->close_standby_message($contenttype, $disposition, $disp_prefix, $format->{ # Generate and return the UI (HTML page) from the appropriate template. $template->process($format->{'template'}, $vars) - || ThrowTemplateError($template->error()); - - -################################################################################ -# Script Conclusion -################################################################################ - -print $cgi->multipart_final() if $serverpush; + || ThrowTemplateError($template->error());
\ No newline at end of file |