diff options
| author | Dylan William Hardison <dylan@hardison.net> | 2017-03-24 04:18:45 +0100 |
|---|---|---|
| committer | Dylan William Hardison <dylan@hardison.net> | 2017-03-24 04:19:06 +0100 |
| commit | 0abf244f409fd91120d35beb65ee4f3a03139a44 (patch) | |
| tree | 42e3435115aea6da353b5ffb8589ed12c9768c33 /extensions/BMO/Extension.pm | |
| parent | 03d25686135afdd93c33e26f6a2532bcfdf023c9 (diff) | |
| download | bugzilla-0abf244f409fd91120d35beb65ee4f3a03139a44.tar.gz bugzilla-0abf244f409fd91120d35beb65ee4f3a03139a44.tar.xz | |
Bug 1349899 - Clean up invalid mozreview urls on attachment page
Diffstat (limited to 'extensions/BMO/Extension.pm')
| -rw-r--r-- | extensions/BMO/Extension.pm | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/extensions/BMO/Extension.pm b/extensions/BMO/Extension.pm index 1640bd076..40ab8424e 100644 --- a/extensions/BMO/Extension.pm +++ b/extensions/BMO/Extension.pm @@ -1152,7 +1152,8 @@ sub _detect_attached_url { return unless defined $url; return if length($url) > 256; $url = trim($url); - return if $url =~ /\s/; + # ignore urls that contain unescaped characters outside of the range mentioned in RFC 3986 section 2 + return if $url =~ m<[^A-Za-z0-9._~:/?#\[\]@!\$&'()*+,;=`.%-]>; foreach my $key (keys %autodetect_attach_urls) { if ($url =~ $autodetect_attach_urls{$key}->{regex}) { |