no bug - reformat all the code using the new perltidy rules

4 files changed, 122 insertions, 113 deletions

diff --git a/extensions/BMO/bin/bug_1022707.pl b/extensions/BMO/bin/bug_1022707.pl
index 4d48db01d..31afa7d05 100755
--- a/extensions/BMO/bin/bug_1022707.pl
+++ b/extensions/BMO/bin/bug_1022707.pl
@@ -37,8 +37,10 @@ print "About to fix $total flags\n";
 print "Press <enter> to start, or ^C to cancel...\n";
 readline;
 
-my $update_fsa_sql= "UPDATE flag_state_activity SET type_id = 4 WHERE " . $dbh->sql_in('flag_id', $flag_ids);
-my $update_flags_sql = "UPDATE flags SET type_id = 4 WHERE " . $dbh->sql_in('id', $flag_ids);
+my $update_fsa_sql = "UPDATE flag_state_activity SET type_id = 4 WHERE "
+  . $dbh->sql_in('flag_id', $flag_ids);
+my $update_flags_sql
+  = "UPDATE flags SET type_id = 4 WHERE " . $dbh->sql_in('id', $flag_ids);
 
 $dbh->bz_start_transaction();
 $dbh->do($update_fsa_sql);
diff --git a/extensions/BMO/bin/bug_1093952.pl b/extensions/BMO/bin/bug_1093952.pl
index fd891f4ae..f52427284 100755
--- a/extensions/BMO/bin/bug_1093952.pl
+++ b/extensions/BMO/bin/bug_1093952.pl
@@ -23,14 +23,17 @@ Bugzilla->usage_mode(USAGE_MODE_CMDLINE);
 
 my $dbh = Bugzilla->dbh;
 
-my $infra     = Bugzilla::Product->check({ name => 'Infrastructure & Operations' });
-my $relops_id = Bugzilla::Component->check({ product => $infra, name => 'RelOps' })->id;
-my $puppet_id = Bugzilla::Component->check({ product => $infra, name => 'RelOps: Puppet' })->id;
-my $infra_id  = $infra->id;
-my $components = $dbh->sql_in('component_id', [ $relops_id, $puppet_id ]);
+my $infra = Bugzilla::Product->check({name => 'Infrastructure & Operations'});
+my $relops_id
+  = Bugzilla::Component->check({product => $infra, name => 'RelOps'})->id;
+my $puppet_id
+  = Bugzilla::Component->check({product => $infra, name => 'RelOps: Puppet'})
+  ->id;
+my $infra_id = $infra->id;
+my $components = $dbh->sql_in('component_id', [$relops_id, $puppet_id]);
 
 print "Searching for bugs..\n";
-my $bugs = $dbh->selectall_arrayref(<<EOF, { Slice => {} });
+my $bugs = $dbh->selectall_arrayref(<<EOF, {Slice => {}});
     SELECT
         bug_id,
         product_id,
@@ -52,9 +55,9 @@ printf "About to fix %s bugs\n", scalar(@$bugs);
 print "Press <Ctrl-C> to stop or <Enter> to continue...\n";
 getc();
 
-my $nobody = Bugzilla::User->check({ name => Bugzilla->params->{'nobody_user'} });
-my $field  = Bugzilla::Field->check({ name => 'status_whiteboard' });
-my $when   = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
+my $nobody = Bugzilla::User->check({name => Bugzilla->params->{'nobody_user'}});
+my $field = Bugzilla::Field->check({name => 'status_whiteboard'});
+my $when = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
 
 my $sth_bugs = $dbh->prepare("
     UPDATE bugs
@@ -70,22 +73,25 @@ my $sth_activity = $dbh->prepare("
 
 $dbh->bz_start_transaction();
 foreach my $bug (@$bugs) {
-    my $bug_id = $bug->{bug_id};
-    my $whiteboard = $bug->{status_whiteboard};
-    print "bug $bug_id\n  $whiteboard\n";
+  my $bug_id     = $bug->{bug_id};
+  my $whiteboard = $bug->{status_whiteboard};
+  print "bug $bug_id\n  $whiteboard\n";
 
-    my $updated = $whiteboard;
-    $updated =~ s#\[kanban:engops:https://kanbanize\.com/ctrl_board/6/[^\]]*\]\s*##g;
-    if ($bug->{product_id} == $infra->id
-        && $bug->{component_id} != $relops_id
-        && $bug->{component_id} != $puppet_id
-    ) {
-        $updated =~ s#\[kanban:engops:https://mozilla\.kanbanize\.com/ctrl_board/6/[^\]]*\]\s*##g;
-    }
-    print "  $updated\n";
+  my $updated = $whiteboard;
+  $updated
+    =~ s#\[kanban:engops:https://kanbanize\.com/ctrl_board/6/[^\]]*\]\s*##g;
+  if ( $bug->{product_id} == $infra->id
+    && $bug->{component_id} != $relops_id
+    && $bug->{component_id} != $puppet_id)
+  {
+    $updated
+      =~ s#\[kanban:engops:https://mozilla\.kanbanize\.com/ctrl_board/6/[^\]]*\]\s*##g;
+  }
+  print "  $updated\n";
 
-    $sth_bugs->execute($updated, $when, $when, $bug_id);
-    $sth_activity->execute($bug_id, $nobody->id, $when, $field->id, $whiteboard, $updated);
+  $sth_bugs->execute($updated, $when, $when, $bug_id);
+  $sth_activity->execute($bug_id, $nobody->id, $when, $field->id, $whiteboard,
+    $updated);
 }
 $dbh->bz_commit_transaction();
 
diff --git a/extensions/BMO/bin/bug_1141452.pl b/extensions/BMO/bin/bug_1141452.pl
index 155c4704c..56b63db91 100755
--- a/extensions/BMO/bin/bug_1141452.pl
+++ b/extensions/BMO/bin/bug_1141452.pl
@@ -13,8 +13,8 @@ use 5.10.1;
 use lib qw(. lib local/lib/perl5);
 
 BEGIN {
-    use Bugzilla;
-    Bugzilla->extensions;
+  use Bugzilla;
+  Bugzilla->extensions;
 }
 
 use Bugzilla::Constants qw( USAGE_MODE_CMDLINE );
@@ -24,14 +24,17 @@ use Bugzilla::User;
 Bugzilla->usage_mode(USAGE_MODE_CMDLINE);
 my $dbh = Bugzilla->dbh;
 
-my $blocking_b2g = Bugzilla::Extension::TrackingFlags::Flag->check({ name => 'cf_blocking_b2g' });
-my $tracking_b2g = Bugzilla::Extension::TrackingFlags::Flag->check({ name => 'cf_tracking_b2g' });
+my $blocking_b2g = Bugzilla::Extension::TrackingFlags::Flag->check(
+  {name => 'cf_blocking_b2g'});
+my $tracking_b2g = Bugzilla::Extension::TrackingFlags::Flag->check(
+  {name => 'cf_tracking_b2g'});
 
 die "tracking-b2g does not have a 'backlog' value\n"
-    unless grep { $_->value eq 'backlog' } @{ $tracking_b2g->values };
+  unless grep { $_->value eq 'backlog' } @{$tracking_b2g->values};
 
 print "Searching for bugs..\n";
-my $flags = $dbh->selectall_arrayref(<<EOF, { Slice => {} }, $blocking_b2g->flag_id, $tracking_b2g->flag_id);
+my $flags = $dbh->selectall_arrayref(
+  <<EOF, {Slice => {}}, $blocking_b2g->flag_id, $tracking_b2g->flag_id);
     SELECT
         bugs.bug_id,
         blocking_b2g.id id,
@@ -50,54 +53,59 @@ printf "About to fix %s bugs\n", scalar(@$flags);
 print "Press <Ctrl-C> to stop or <Enter> to continue...\n";
 getc();
 
-my $nobody = Bugzilla::User->check({ name => Bugzilla->params->{'nobody_user'} });
-my $when   = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
+my $nobody = Bugzilla::User->check({name => Bugzilla->params->{'nobody_user'}});
+my $when = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
 
 $dbh->bz_start_transaction();
 foreach my $flag (@$flags) {
-    if (!$flag->{value}) {
-        print $flag->{bug_id}, ": changing blocking_b2g:backlog -> tracking_b2g:backlog\n";
-        # no tracking_b2g value, change blocking_b2g:backlog -> tracking_b2g:backlog
-        $dbh->do(
-            "UPDATE tracking_flags_bugs SET tracking_flag_id = ? WHERE id = ?",
-            undef,
-            $tracking_b2g->flag_id, $flag->{id},
-        );
-        $dbh->do(
-            "UPDATE bugs SET delta_ts = ?, lastdiffed = ? WHERE bug_id = ?",
-            undef,
-            $when, $when, $flag->{bug_id},
-        );
-        $dbh->do(
-            "INSERT INTO bugs_activity(bug_id, who, bug_when, fieldid, removed, added) VALUES (?, ?, ?, ?, ?, ?)",
-            undef,
-            $flag->{bug_id}, $nobody->id, $when, $blocking_b2g->id, 'backlog', '---',
-        );
-        $dbh->do(
-            "INSERT INTO bugs_activity(bug_id, who, bug_when, fieldid, removed, added) VALUES (?, ?, ?, ?, ?, ?)",
-            undef,
-            $flag->{bug_id}, $nobody->id, $when, $tracking_b2g->id, '---', 'backlog',
-        );
-    }
-    elsif ($flag->{value}) {
-        print $flag->{bug_id}, ": deleting blocking_b2g:backlog\n";
-        # tracking_b2g already has a value, just delete blocking_b2g:backlog
-        $dbh->do(
-            "DELETE FROM tracking_flags_bugs WHERE id = ?",
-            undef,
-            $flag->{id},
-        );
-        $dbh->do(
-            "UPDATE bugs SET delta_ts = ?, lastdiffed = ? WHERE bug_id = ?",
-            undef,
-            $when, $when, $flag->{bug_id},
-        );
-        $dbh->do(
-            "INSERT INTO bugs_activity(bug_id, who, bug_when, fieldid, removed, added) VALUES (?, ?, ?, ?, ?, ?)",
-            undef,
-            $flag->{bug_id}, $nobody->id, $when, $blocking_b2g->id, 'backlog', '---',
-        );
-    }
+  if (!$flag->{value}) {
+    print $flag->{bug_id},
+      ": changing blocking_b2g:backlog -> tracking_b2g:backlog\n";
+
+    # no tracking_b2g value, change blocking_b2g:backlog -> tracking_b2g:backlog
+    $dbh->do("UPDATE tracking_flags_bugs SET tracking_flag_id = ? WHERE id = ?",
+      undef, $tracking_b2g->flag_id, $flag->{id},);
+    $dbh->do("UPDATE bugs SET delta_ts = ?, lastdiffed = ? WHERE bug_id = ?",
+      undef, $when, $when, $flag->{bug_id},);
+    $dbh->do(
+      "INSERT INTO bugs_activity(bug_id, who, bug_when, fieldid, removed, added) VALUES (?, ?, ?, ?, ?, ?)",
+      undef,
+      $flag->{bug_id},
+      $nobody->id,
+      $when,
+      $blocking_b2g->id,
+      'backlog',
+      '---',
+    );
+    $dbh->do(
+      "INSERT INTO bugs_activity(bug_id, who, bug_when, fieldid, removed, added) VALUES (?, ?, ?, ?, ?, ?)",
+      undef,
+      $flag->{bug_id},
+      $nobody->id,
+      $when,
+      $tracking_b2g->id,
+      '---',
+      'backlog',
+    );
+  }
+  elsif ($flag->{value}) {
+    print $flag->{bug_id}, ": deleting blocking_b2g:backlog\n";
+
+    # tracking_b2g already has a value, just delete blocking_b2g:backlog
+    $dbh->do("DELETE FROM tracking_flags_bugs WHERE id = ?", undef, $flag->{id},);
+    $dbh->do("UPDATE bugs SET delta_ts = ?, lastdiffed = ? WHERE bug_id = ?",
+      undef, $when, $when, $flag->{bug_id},);
+    $dbh->do(
+      "INSERT INTO bugs_activity(bug_id, who, bug_when, fieldid, removed, added) VALUES (?, ?, ?, ?, ?, ?)",
+      undef,
+      $flag->{bug_id},
+      $nobody->id,
+      $when,
+      $blocking_b2g->id,
+      'backlog',
+      '---',
+    );
+  }
 }
 $dbh->bz_commit_transaction();
 
diff --git a/extensions/BMO/bin/migrate-github-pull-requests.pl b/extensions/BMO/bin/migrate-github-pull-requests.pl
index c39778a4a..c8afdedfb 100755
--- a/extensions/BMO/bin/migrate-github-pull-requests.pl
+++ b/extensions/BMO/bin/migrate-github-pull-requests.pl
@@ -22,9 +22,9 @@ use Bugzilla::Install::Util qw(indicate_progress);
 use Bugzilla::User;
 use Bugzilla::Util qw(trim);
 
-my $dbh = Bugzilla->dbh;
-my $nobody = Bugzilla::User->check({ name => Bugzilla->params->{'nobody_user'} });
-my $field = Bugzilla::Field->check({ name => 'attachments.mimetype' });
+my $dbh    = Bugzilla->dbh;
+my $nobody = Bugzilla::User->check({name => Bugzilla->params->{'nobody_user'}});
+my $field  = Bugzilla::Field->check({name => 'attachments.mimetype'});
 
 # grab list of suitable attachments
 
@@ -42,7 +42,7 @@ SELECT attachments.attach_id,
        AND LENGTH(thedata) <= 256
 EOF
 print "Searching for suitable attachments..\n";
-my $attachments = $dbh->selectall_arrayref($sql, { Slice => {} });
+my $attachments = $dbh->selectall_arrayref($sql, {Slice => {}});
 my ($current, $total, $updated) = (1, scalar(@$attachments), 0);
 
 die "No suitable attachments found\n" unless $total;
@@ -52,39 +52,32 @@ print "Press <enter> to start, or ^C to cancel...\n";
 <>;
 
 foreach my $attachment (@$attachments) {
-    indicate_progress({ current => $current++, total => $total, every => 25 });
-
-    # check payload
-    my $url = trim($attachment->{thedata});
-    next if $url =~ /\s/;
-    next unless $url =~ m#^https://github\.com/[^/]+/[^/]+/pull/\d+\/?$#i;
-
-    $dbh->bz_start_transaction;
-
-    # set content-type
-    $dbh->do(
-        "UPDATE attachments SET mimetype = ? WHERE attach_id = ?",
-        undef,
-        'text/x-github-pull-request', $attachment->{attach_id}
-    );
-
-    # insert into bugs_activity
-    my $timestamp = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
-    $dbh->do(
-        "INSERT INTO bugs_activity(bug_id, who, bug_when, fieldid, removed, added)
-                     VALUES (?, ?, ?, ?, ?, ?)",
-        undef,
-        $attachment->{bug_id}, $nobody->id, $timestamp, $field->id,
-        $attachment->{mimetype}, 'text/x-github-pull-request'
-    );
-    $dbh->do(
-        "UPDATE bugs SET delta_ts = ?, lastdiffed = ? WHERE bug_id = ?",
-        undef,
-        $timestamp, $timestamp, $attachment->{bug_id}
-    );
-
-    $dbh->bz_commit_transaction;
-    $updated++;
+  indicate_progress({current => $current++, total => $total, every => 25});
+
+  # check payload
+  my $url = trim($attachment->{thedata});
+  next if $url =~ /\s/;
+  next unless $url =~ m#^https://github\.com/[^/]+/[^/]+/pull/\d+\/?$#i;
+
+  $dbh->bz_start_transaction;
+
+  # set content-type
+  $dbh->do("UPDATE attachments SET mimetype = ? WHERE attach_id = ?",
+    undef, 'text/x-github-pull-request', $attachment->{attach_id});
+
+  # insert into bugs_activity
+  my $timestamp = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
+  $dbh->do(
+    "INSERT INTO bugs_activity(bug_id, who, bug_when, fieldid, removed, added)
+                     VALUES (?, ?, ?, ?, ?, ?)", undef, $attachment->{bug_id},
+    $nobody->id, $timestamp, $field->id, $attachment->{mimetype},
+    'text/x-github-pull-request'
+  );
+  $dbh->do("UPDATE bugs SET delta_ts = ?, lastdiffed = ? WHERE bug_id = ?",
+    undef, $timestamp, $timestamp, $attachment->{bug_id});
+
+  $dbh->bz_commit_transaction;
+  $updated++;
 }
 
 print "Attachments updated: $updated\n";