diff options
| author | Dylan William Hardison <dylan@hardison.net> | 2018-05-09 16:28:26 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-05-09 16:28:26 +0200 |
| commit | 2c2b5a5644c17e2a9cc2d56fdbea76a25a24280f (patch) | |
| tree | 85fd62c2ec982c67128de472ac1cc3d3904578d9 /extensions/PhabBugz/lib/User.pm | |
| parent | 739676cf4b122cdec12981c2bc3a79c3f54aa7e4 (diff) | |
| download | bugzilla-2c2b5a5644c17e2a9cc2d56fdbea76a25a24280f.tar.gz bugzilla-2c2b5a5644c17e2a9cc2d56fdbea76a25a24280f.tar.xz | |
Revert "Bug 1440086 - Refactor PhabBugz extension code to use new User.pm module for better type checking"
This reverts commit 739676cf4b122cdec12981c2bc3a79c3f54aa7e4.
Diffstat (limited to 'extensions/PhabBugz/lib/User.pm')
| -rw-r--r-- | extensions/PhabBugz/lib/User.pm | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/extensions/PhabBugz/lib/User.pm b/extensions/PhabBugz/lib/User.pm index 9d4e9eef4..3b2d87e60 100644 --- a/extensions/PhabBugz/lib/User.pm +++ b/extensions/PhabBugz/lib/User.pm @@ -116,14 +116,14 @@ sub match { my ( $class, $params ) = @_; # BMO id search takes precedence if bugzilla_ids is used. - my $bugzilla_ids = delete $params->{ids}; + my $bugzilla_ids = delete $params->{bugzilla_ids}; if ($bugzilla_ids) { my $bugzilla_data = $class->get_phab_bugzilla_ids( { ids => $bugzilla_ids } ); $params->{phids} = [ map { $_->{phid} } @$bugzilla_data ]; } - return [] if !@{ $params->{phids} }; + return [] if !$params->{phids}; # Look for BMO external user id in external-accounts attachment my $data = { @@ -177,7 +177,6 @@ sub get_phab_bugzilla_ids { # Store new values in memcache for later retrieval foreach my $user ( @{ $result->{result} } ) { - next if !$user->{phid}; $memcache->set( { key => "phab_user_bugzilla_id_" . $user->{id}, |