summaryrefslogtreecommitdiffstats
path: root/extensions/PhabBugz
diff options
context:
space:
mode:
authordklawren <dklawren@users.noreply.github.com>2018-05-11 18:13:35 +0200
committerGitHub <noreply@github.com>2018-05-11 18:13:35 +0200
commita5b780358d0e8c9cd611a644b3d6168daac711e3 (patch)
treee32c8f45f1122a45f8ccdc972dbde7250dce668a /extensions/PhabBugz
parent2c2b5a5644c17e2a9cc2d56fdbea76a25a24280f (diff)
downloadbugzilla-a5b780358d0e8c9cd611a644b3d6168daac711e3.tar.gz
bugzilla-a5b780358d0e8c9cd611a644b3d6168daac711e3.tar.xz
Bug 1460466 - Phab bot does not create r+ for acceptance when there are still blocking reviewers
Diffstat (limited to 'extensions/PhabBugz')
-rw-r--r--extensions/PhabBugz/lib/Feed.pm8
1 files changed, 3 insertions, 5 deletions
diff --git a/extensions/PhabBugz/lib/Feed.pm b/extensions/PhabBugz/lib/Feed.pm
index 821ec6527..a0012cc10 100644
--- a/extensions/PhabBugz/lib/Feed.pm
+++ b/extensions/PhabBugz/lib/Feed.pm
@@ -412,11 +412,9 @@ sub process_revision_change {
# REVIEWER STATUSES
my (@accepted_phids, @denied_phids, @accepted_user_ids, @denied_user_ids);
- unless ($revision->status eq 'changes-planned' || $revision->status eq 'needs-review') {
- foreach my $reviewer (@{ $revision->reviewers }) {
- push(@accepted_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'accepted';
- push(@denied_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'rejected';
- }
+ foreach my $reviewer (@{ $revision->reviewers }) {
+ push(@accepted_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'accepted';
+ push(@denied_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'rejected';
}
my $phab_users = get_phab_bmo_ids({ phids => \@accepted_phids });