summaryrefslogtreecommitdiffstats
path: root/extensions/Push/lib
diff options
context:
space:
mode:
authordklawren <dklawren@users.noreply.github.com>2018-06-28 19:30:34 +0200
committerGitHub <noreply@github.com>2018-06-28 19:30:34 +0200
commitf63319ac7da3fc3f9107c21ad715b8af9566fde4 (patch)
treed9caee13f60d320160921ac84b8cdd677e6663cf /extensions/Push/lib
parent92404e600ecfb71af823470b83b594ce3ba88eac (diff)
downloadbugzilla-f63319ac7da3fc3f9107c21ad715b8af9566fde4.tar.gz
bugzilla-f63319ac7da3fc3f9107c21ad715b8af9566fde4.tar.xz
Bug 1469378 - Update feed daemon to only manage subscribers on a revision if the bug is private, otherwise leave it alone
Diffstat (limited to 'extensions/Push/lib')
-rw-r--r--extensions/Push/lib/Connector/Phabricator.pm16
1 files changed, 9 insertions, 7 deletions
diff --git a/extensions/Push/lib/Connector/Phabricator.pm b/extensions/Push/lib/Connector/Phabricator.pm
index 5d5e4e639..e59ba6c0d 100644
--- a/extensions/Push/lib/Connector/Phabricator.pm
+++ b/extensions/Push/lib/Connector/Phabricator.pm
@@ -108,13 +108,15 @@ sub send {
# Subscriber list of the private revision should always match
# the bug roles such as assignee, qa contact, and cc members.
- Bugzilla->audit(sprintf(
- 'Updating subscribers for %s for bug %s',
- $revision->id,
- $bug->id
- ));
- my $subscribers = get_bug_role_phids($bug);
- $revision->set_subscribers($subscribers) if $subscribers;
+ if (!$is_public) {
+ Bugzilla->audit(sprintf(
+ 'Updating subscribers for %s for bug %s',
+ $revision->id,
+ $bug->id
+ ));
+ my $subscribers = get_bug_role_phids($bug);
+ $revision->set_subscribers($subscribers) if $subscribers;
+ }
$revision->update();
}