summaryrefslogtreecommitdiffstats
path: root/extensions
diff options
context:
space:
mode:
authordklawren <dklawren@users.noreply.github.com>2018-06-26 04:35:56 +0200
committerGitHub <noreply@github.com>2018-06-26 04:35:56 +0200
commit7a61871a05c6e4e4df8313c4ba93143101cbb9be (patch)
tree9e68325742d71246d77b0fddc3bd5c9177740919 /extensions
parent7094db8e78304f4f76d48ba230f07fab5c9d0daf (diff)
downloadbugzilla-7a61871a05c6e4e4df8313c4ba93143101cbb9be.tar.gz
bugzilla-7a61871a05c6e4e4df8313c4ba93143101cbb9be.tar.xz
Bug 1470966 - "Status" column in Phabricator dashboard isn't very useful
Diffstat (limited to 'extensions')
-rw-r--r--extensions/MyDashboard/web/js/flags.js2
-rw-r--r--extensions/PhabBugz/lib/Util.pm11
-rw-r--r--extensions/PhabBugz/lib/WebService.pm1
3 files changed, 1 insertions, 13 deletions
diff --git a/extensions/MyDashboard/web/js/flags.js b/extensions/MyDashboard/web/js/flags.js
index b56559ae3..425e42e57 100644
--- a/extensions/MyDashboard/web/js/flags.js
+++ b/extensions/MyDashboard/web/js/flags.js
@@ -180,8 +180,6 @@ $(function () {
columns: [
{ key: 'author_email', label: 'Requester', sortable: true,
formattter: phabAuthorFormatter, allowHTML: true },
- { key: 'id', label: 'Status', sortable: true,
- nodeFormatter: phabRowFormatter, allowHTML: true },
{ key: 'bug_id', label: 'Bug', sortable: true,
formatter: bugLinkFormatter, allowHTML: true },
{ key: 'updated', label: 'Updated', sortable: true,
diff --git a/extensions/PhabBugz/lib/Util.pm b/extensions/PhabBugz/lib/Util.pm
index c4c9c7992..214bc3fb7 100644
--- a/extensions/PhabBugz/lib/Util.pm
+++ b/extensions/PhabBugz/lib/Util.pm
@@ -274,16 +274,7 @@ sub get_needs_review {
ThrowCodeError('phabricator_api_error', { reason => 'Malformed Response' })
unless exists $diffs->{result}{data};
- # extract this reviewer's status from 'attachments'
- my @result;
- foreach my $diff (@{ $diffs->{result}{data} }) {
- my $attachments = delete $diff->{attachments};
- my $reviewers = $attachments->{reviewers}{reviewers};
- my $review = first { $_->{reviewerPHID} eq $phab_user->phid } @$reviewers;
- $diff->{fields}{review_status} = $review->{status};
- push @result, $diff;
- }
- return \@result;
+ return $diffs->{result}{data};
}
1;
diff --git a/extensions/PhabBugz/lib/WebService.pm b/extensions/PhabBugz/lib/WebService.pm
index 5ca811d58..0239ccf74 100644
--- a/extensions/PhabBugz/lib/WebService.pm
+++ b/extensions/PhabBugz/lib/WebService.pm
@@ -116,7 +116,6 @@ sub needs_review {
foreach my $review (@$reviews) {
my $review_flat = {
id => $review->{id},
- status => $review->{fields}{review_status},
title => $review->{fields}{title},
url => Bugzilla->params->{phabricator_base_uri} . 'D' . $review->{id},
};