diff options
author | Perl Tidy <perltidy@bugzilla.org> | 2018-12-05 21:38:52 +0100 |
---|---|---|
committer | Dylan William Hardison <dylan@hardison.net> | 2018-12-05 23:49:08 +0100 |
commit | 8ec8da0491ad89604700b3e29a227966f6d84ba1 (patch) | |
tree | 9d270f173330ca19700e0ba9f2ee931300646de1 /qa/extensions | |
parent | a7bb5a65b71644d9efce5fed783ed545b9336548 (diff) | |
download | bugzilla-8ec8da0491ad89604700b3e29a227966f6d84ba1.tar.gz bugzilla-8ec8da0491ad89604700b3e29a227966f6d84ba1.tar.xz |
no bug - reformat all the code using the new perltidy rules
Diffstat (limited to 'qa/extensions')
-rw-r--r-- | qa/extensions/QA/Config.pm | 6 | ||||
-rw-r--r-- | qa/extensions/QA/Extension.pm | 74 | ||||
-rw-r--r-- | qa/extensions/QA/lib/Util.pm | 10 |
3 files changed, 44 insertions, 46 deletions
diff --git a/qa/extensions/QA/Config.pm b/qa/extensions/QA/Config.pm index 59799ec6b..627753855 100644 --- a/qa/extensions/QA/Config.pm +++ b/qa/extensions/QA/Config.pm @@ -11,10 +11,8 @@ use strict; use constant NAME => 'QA'; -use constant REQUIRED_MODULES => [ -]; +use constant REQUIRED_MODULES => []; -use constant OPTIONAL_MODULES => [ -]; +use constant OPTIONAL_MODULES => []; __PACKAGE__->NAME; diff --git a/qa/extensions/QA/Extension.pm b/qa/extensions/QA/Extension.pm index b5f404d74..764bbb03b 100644 --- a/qa/extensions/QA/Extension.pm +++ b/qa/extensions/QA/Extension.pm @@ -20,52 +20,52 @@ use Bugzilla::User; our $VERSION = '1.0'; sub page_before_template { - my ($self, $args) = @_; - return if $args->{page_id} ne 'qa/email_in.html'; + my ($self, $args) = @_; + return if $args->{page_id} ne 'qa/email_in.html'; - my $template = Bugzilla->template; - my $cgi = Bugzilla->cgi; - print $cgi->header; + my $template = Bugzilla->template; + my $cgi = Bugzilla->cgi; + print $cgi->header; - # Needed to make sure he can access and edit bugs. - my $user = Bugzilla::User->check($cgi->param('sender')); - Bugzilla->set_user($user); + # Needed to make sure he can access and edit bugs. + my $user = Bugzilla::User->check($cgi->param('sender')); + Bugzilla->set_user($user); - my ($output, $tmpl_file); - my $action = $cgi->param('action') || ''; - my $vars = { sender => $user, action => $action, pid => $$ }; + my ($output, $tmpl_file); + my $action = $cgi->param('action') || ''; + my $vars = {sender => $user, action => $action, pid => $$}; - if ($action eq 'create') { - $tmpl_file = 'qa/create_bug.txt.tmpl'; - } - elsif ($action eq 'create_with_headers') { - $tmpl_file = 'qa/create_bug_with_headers.txt.tmpl'; - } - elsif ($action =~ /^update(_with_headers)?$/) { - my $f = $1 || ''; - $tmpl_file = "qa/update_bug$f.txt.tmpl"; - my $bug = Bugzilla::Bug->check($cgi->param('bug_id')); - $vars->{bug_id} = $bug->id; - } - else { - ThrowUserError('unknown_action', { action => $action }); - } + if ($action eq 'create') { + $tmpl_file = 'qa/create_bug.txt.tmpl'; + } + elsif ($action eq 'create_with_headers') { + $tmpl_file = 'qa/create_bug_with_headers.txt.tmpl'; + } + elsif ($action =~ /^update(_with_headers)?$/) { + my $f = $1 || ''; + $tmpl_file = "qa/update_bug$f.txt.tmpl"; + my $bug = Bugzilla::Bug->check($cgi->param('bug_id')); + $vars->{bug_id} = $bug->id; + } + else { + ThrowUserError('unknown_action', {action => $action}); + } - $template->process($tmpl_file, $vars, \$output) - or ThrowTemplateError($template->error()); + $template->process($tmpl_file, $vars, \$output) + or ThrowTemplateError($template->error()); - my $file = "/tmp/email_in_$$.txt"; - open(FH, '>', $file); - print FH $output; - close FH; + my $file = "/tmp/email_in_$$.txt"; + open(FH, '>', $file); + print FH $output; + close FH; - $output = `email_in.pl -v < $file 2>&1`; - unlink $file; + $output = `email_in.pl -v < $file 2>&1`; + unlink $file; - parse_output($output, $vars); + parse_output($output, $vars); - $template->process('qa/results.html.tmpl', $vars) - or ThrowTemplateError($template->error()); + $template->process('qa/results.html.tmpl', $vars) + or ThrowTemplateError($template->error()); } __PACKAGE__->NAME; diff --git a/qa/extensions/QA/lib/Util.pm b/qa/extensions/QA/lib/Util.pm index 9bc2d8dbb..9b9026343 100644 --- a/qa/extensions/QA/lib/Util.pm +++ b/qa/extensions/QA/lib/Util.pm @@ -11,15 +11,15 @@ use strict; use base qw(Exporter); our @EXPORT = qw( - parse_output + parse_output ); sub parse_output { - my ($output, $vars) = @_; + my ($output, $vars) = @_; - $vars->{error} = ($output =~ /software error/i) ? 1 : 0; - $vars->{output} = $output; - $vars->{bug_id} ||= ($output =~ /Created bug (\d+)/i) ? $1 : undef; + $vars->{error} = ($output =~ /software error/i) ? 1 : 0; + $vars->{output} = $output; + $vars->{bug_id} ||= ($output =~ /Created bug (\d+)/i) ? $1 : undef; } 1; |