Bug 1428642 - Fix minor bugs on new global header

* The magnifier icon on the search bar should not trigger search as reported in 
   https://twitter.com/colinjoy/status/949035254949523457
* The search dropdown should show Saved Searches Edit link as suggested in my UX analysis
* Remove the CSS transition on the More Tools button for consistency. I didn't add the transition;
   it's default style for buttons
* Fix the position of the arrow/triangle on dropdown lists. An error of 1px.
* Add `user-select: none;` to `#header` https://developer.mozilla.org/en-US/docs/Web/CSS/user 
  select

4 files changed, 5 insertions, 5 deletions

diff --git a/qa/t/lib/QA/Util.pm b/qa/t/lib/QA/Util.pm
index f80837c0e..5d041d560 100644
--- a/qa/t/lib/QA/Util.pm
+++ b/qa/t/lib/QA/Util.pm
@@ -266,7 +266,7 @@ sub go_to_bug {
     my ($sel, $bug_id) = @_;
 
     $sel->type_ok("quicksearch_top", $bug_id);
-    $sel->click_ok("find_top", undef, "Go to bug $bug_id");
+    $sel->submit("header-search");
     $sel->wait_for_page_to_load_ok(WAIT_TIME);
     my $bug_title = $sel->get_title();
     utf8::encode($bug_title) if utf8::is_utf8($bug_title);
diff --git a/qa/t/test_bug_edit.t b/qa/t/test_bug_edit.t
index 8e42a139d..07a64876b 100644
--- a/qa/t/test_bug_edit.t
+++ b/qa/t/test_bug_edit.t
@@ -161,7 +161,7 @@ logout($sel);
 
 log_in($sel, $config, 'unprivileged');
 $sel->type_ok("quicksearch_top", $bug1_id);
-$sel->click_ok("find_top");
+$sel->submit("header-search");
 $sel->wait_for_page_to_load_ok(WAIT_TIME);
 $sel->title_is("Access Denied");
 $sel->is_text_present_ok("You are not authorized to access bug $bug1_id");
diff --git a/qa/t/test_qa_contact.t b/qa/t/test_qa_contact.t
index b75044806..3795e2edc 100644
--- a/qa/t/test_qa_contact.t
+++ b/qa/t/test_qa_contact.t
@@ -94,7 +94,7 @@ logout($sel);
 # to the Master group.
 
 $sel->type_ok("quicksearch_top", $bug1_id);
-$sel->click_ok("find_top");
+$sel->submit("header-search");
 $sel->wait_for_page_to_load_ok(WAIT_TIME);
 $sel->title_is("Access Denied");
 $sel->is_text_present_ok("You are not authorized to access bug");
diff --git a/qa/t/test_shared_searches.t b/qa/t/test_shared_searches.t
index 98237f756..a4b2ac9ce 100644
--- a/qa/t/test_shared_searches.t
+++ b/qa/t/test_shared_searches.t
@@ -23,7 +23,7 @@ set_parameters($sel, { "Group Security" => {"querysharegroup" => {type => "selec
 # Create new saved search and call it 'Shared Selenium buglist'.
 
 $sel->type_ok("quicksearch_top", ":TestProduct Selenium");
-$sel->click_ok("find_top");
+$sel->submit("header-search");
 $sel->wait_for_page_to_load_ok(WAIT_TIME);
 $sel->title_like(qr/^Bug List:/);
 $sel->type_ok("save_newqueryname", "Shared Selenium buglist");
@@ -96,7 +96,7 @@ ok(!$sel->is_text_present("Shared Selenium buglist"), "Shared query no longer di
 # Create your own saved search, and share it with the canconfirm group.
 
 $sel->type_ok("quicksearch_top", ":TestProduct sw:helpwanted");
-$sel->click_ok("find_top");
+$sel->submit("header-search");
 $sel->wait_for_page_to_load_ok(WAIT_TIME);
 $sel->title_like(qr/^Bug List:/);
 $sel->type_ok("save_newqueryname", "helpwanted");