summaryrefslogtreecommitdiffstats
path: root/request.cgi
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2016-04-14 21:03:00 +0200
committerFrédéric Buclin <LpSolit@gmail.com>2016-04-14 21:03:00 +0200
commit90d86a9744883ccc120a0a955ffade72990e1505 (patch)
tree07fd038fc41a2de0259f2f7c6a9de0d55e8a1e34 /request.cgi
parentae22da8710d00232d28b7c6b9093d2b7e33b0627 (diff)
downloadbugzilla-90d86a9744883ccc120a0a955ffade72990e1505.tar.gz
bugzilla-90d86a9744883ccc120a0a955ffade72990e1505.tar.xz
Bug 1088022 - Bump min version to CGI 4.09
r=dkl
Diffstat (limited to 'request.cgi')
-rwxr-xr-xrequest.cgi14
1 files changed, 7 insertions, 7 deletions
diff --git a/request.cgi b/request.cgi
index 95e4fd1fd..54b568a84 100755
--- a/request.cgi
+++ b/request.cgi
@@ -84,8 +84,8 @@ sub queue {
my $userid = $user->id;
my $vars = {};
- my $status = validateStatus($cgi->param('status'));
- my $form_group = validateGroup($cgi->param('group'));
+ my $status = validateStatus(scalar $cgi->param('status'));
+ my $form_group = validateGroup(scalar $cgi->param('group'));
my $query =
# Select columns describing each flag, the bug/attachment on which
@@ -167,15 +167,15 @@ sub queue {
my $do_union = $cgi->param('do_union');
# Filter results by exact email address of requester or requestee.
- if (defined $cgi->param('requester') && $cgi->param('requester') ne "") {
- my $requester = $dbh->quote($cgi->param('requester'));
+ if (my $requester = $cgi->param('requester')) {
+ $requester = $dbh->quote($requester);
trick_taint($requester); # Quoted above
push(@criteria, $dbh->sql_istrcmp('requesters.login_name', $requester));
push(@excluded_columns, 'requester') unless $do_union;
}
- if (defined $cgi->param('requestee') && $cgi->param('requestee') ne "") {
- if ($cgi->param('requestee') ne "-") {
- my $requestee = $dbh->quote($cgi->param('requestee'));
+ if (my $requestee = $cgi->param('requestee')) {
+ if ($requestee ne '-') {
+ $requestee = $dbh->quote($requestee);
trick_taint($requestee); # Quoted above
push(@criteria, $dbh->sql_istrcmp('requestees.login_name', $requestee));
}