Bug 167978 - Fix Throw*Error l10n regressions and add a test to catch more. Patch by gerv; r=bbaetz.

1 files changed, 27 insertions, 1 deletions

diff --git a/t/002goodperl.t b/t/002goodperl.t
index 1431e7fe8..973a5fb88 100644
--- a/t/002goodperl.t
+++ b/t/002goodperl.t
@@ -44,7 +44,7 @@ use lib 't';
 
 use Support::Files;
 
-use Test::More tests => (scalar(@Support::Files::testitems) * 2);
+use Test::More tests => (scalar(@Support::Files::testitems) * 3);
 
 my @testitems = @Support::Files::testitems; # get the files to test.
 
@@ -116,4 +116,30 @@ foreach my $file (@testitems) {
     }
 }
 
+# Check to see that all error messages use tags (for l10n reasons.)
+foreach my $file (@testitems) {
+    $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
+    next if (!$file); # skip null entries
+    if (! open (FILE, $file)) {
+        ok(0,"could not open $file --WARNING");
+        next;
+    }
+    my $lineno = 0;
+    my $error = 0;
+    
+    while (my $file_line = <FILE>) {
+        $lineno++;
+        if ($file_line =~ /Throw.*Error\("(.*?)"/) {
+            if ($1 =~ /\s/) {
+                ok(0,"$file has a Throw*Error call on line $lineno 
+                      which doesn't use a tag --ERROR");
+                $error = 1;       
+            }
+        }
+    }
+    
+    ok(1,"$file uses Throw*Error calls correctly") if !$error;
+    
+    close(FILE);
+}
 exit 0;