Bug 920681: Remove the cellspacing and cellpadding attributes from tables

r/a=justdave

6 files changed, 88 insertions, 152 deletions

diff --git a/template/en/default/bug/activity/table.html.tmpl b/template/en/default/bug/activity/table.html.tmpl
index 4581e5e1d..8b371f0b5 100644
--- a/template/en/default/bug/activity/table.html.tmpl
+++ b/template/en/default/bug/activity/table.html.tmpl
@@ -33,8 +33,8 @@
 [% END %]
 
 [% IF operations.size > 0 %]
-  <table border cellpadding="4">
-    <tr>
+  <table id="bug_activity">
+    <tr class="column_header">
       <th>Who</th>
       <th>When</th>
       <th>What</th>
@@ -44,10 +44,10 @@
 
     [% FOREACH operation = operations %]
       <tr>
-        <td rowspan="[% operation.changes.size %]" valign="top">
+        <td rowspan="[% operation.changes.size %]">
           [% operation.who FILTER email FILTER html %]
         </td>
-        <td rowspan="[% operation.changes.size %]" valign="top">
+        <td rowspan="[% operation.changes.size %]">
           [% operation.when FILTER time %]
         </td>
         [% FOREACH change = operation.changes %]
diff --git a/template/en/default/bug/comments.html.tmpl b/template/en/default/bug/comments.html.tmpl
index 7aa9a34a6..ea3cfd0de 100644
--- a/template/en/default/bug/comments.html.tmpl
+++ b/template/en/default/bug/comments.html.tmpl
@@ -49,7 +49,8 @@
 
 <!-- This auto-sizes the comments and positions the collapse/expand links 
      to the right. -->
-<table class="bz_comment_table" cellpadding="0" cellspacing="0"><tr>
+<table class="bz_comment_table">
+<tr>
 <td>
 
 [% FOREACH comment = comments %]
diff --git a/template/en/default/bug/create/create-guided.html.tmpl b/template/en/default/bug/create/create-guided.html.tmpl
index 7abb8c7dc..64bacf0b1 100644
--- a/template/en/default/bug/create/create-guided.html.tmpl
+++ b/template/en/default/bug/create/create-guided.html.tmpl
@@ -47,22 +47,15 @@ function PutDescription() {
 
 <p>Check the two lists of frequently-reported [% terms.bugs %]:</p>
 
-[%# Include other products if sensible %]
-[% IF product.name == "Firefox" %]
-  [% productstring = "product=Mozilla%20Application%20Suite&amp;product=Firefox" %]
-[% ELSIF product.name == "Thunderbird" %]
-  [% productstring = "product=Mozilla%20Application%20Suite&amp;product=Thunderbird" %]
-[% ELSE %]
-  [% productstring = BLOCK %]product=[% product.name FILTER uri %][% END %]
-[% END %]
-
 <p>
-    <a href="duplicates.cgi?[% productstring %]&amp;format=simple" target="somebugs">All-time Top 100</a> (loaded initially) |
-    <a href="duplicates.cgi?[% productstring %]&amp;format=simple&amp;sortby=delta&amp;reverse=1&amp;maxrows=100&amp;changedsince=14" target="somebugs">Hot in the last two weeks</a>  
+  <a href="duplicates.cgi?product=[% product.name FILTER uri %]&amp;format=simple"
+     target="somebugs">All-time Top 100</a> (loaded initially) |
+  <a href="duplicates.cgi?product=[% product.name FILTER uri %]&amp;format=simple&amp;sortby=delta&amp;reverse=1&amp;maxrows=100&amp;changedsince=14"
+     target="somebugs">Hot in the last two weeks</a>
 </p>
 
 <iframe name="somebugs" id="somebugs"
-  src="duplicates.cgi?[% productstring %]&amp;format=simple">
+  src="duplicates.cgi?product=[% product.name FILTER uri %]&amp;format=simple">
 </iframe>
 
 <p>
@@ -70,7 +63,7 @@ function PutDescription() {
     a few key words having to do with your [% terms.bug %] in this box.
     For example: <kbd><b>pop3 mail</b></kbd> or <kbd><b>copy paste</b></kbd>.
     The results will appear above.
-  </p>
+</p>
 
 [%# All bugs opened inside the past six months %]
   <form action="buglist.cgi" method="get" target="somebugs">
@@ -78,16 +71,6 @@ function PutDescription() {
     <input type="hidden" name="order" value="relevance desc">
     <input type="hidden" name="bug_status" value="__all__">
     <input type="hidden" name="product" value="[% product.name FILTER html %]">
-    [% IF product.name == "Firefox" OR 
-          product.name == "Thunderbird" OR 
-          product.name == "Mozilla Application Suite" OR
-          product.name == "Camino" %]
-      <input type="hidden" name="product" value="Core">
-      <input type="hidden" name="product" value="Toolkit">
-      <input type="hidden" name="product" value="PSM">
-      <input type="hidden" name="product" value="NSPR">
-      <input type="hidden" name="product" value="NSS">
-    [% END %]      
     <input type="hidden" name="chfieldfrom" value="-6m">
     <input type="hidden" name="chfieldto" value="Now">
     <input type="hidden" name="chfield" value="[Bug creation]">
@@ -112,7 +95,7 @@ function PutDescription() {
   there, tell us all about it.
 </p>
 
-<form method="post" action="post_bug.cgi">
+<form id="guided_form" method="post" action="post_bug.cgi">
   <input type="hidden" name="format" value="guided">
   <input type="hidden" name="assigned_to" value="">
   <input type="hidden" name="priority"
@@ -121,105 +104,77 @@ function PutDescription() {
          value="[% default.version FILTER html %]">
   <input type="hidden" name="token" value="[% token FILTER html %]">
 
-<table valign="top" cellpadding="5" cellspacing="5" border="0">
-
+<table>
   <tr class="guided_form_field">
-    <td align="right" valign="top">
-      <b>Product</b>
-    </td>
-    <td valign="top">
+    <th>Product</th>
+    <td>
       <input type="hidden" name="product" value="[% product.name FILTER html %]">
       [% product.name FILTER html %]
     </td>
   </tr>
 
   <tr>
-    <td align="right" valign="top">
-      <b>Component</b>
-    </td>
-    <td valign="top">
-      <table border="0" cellpadding="0" cellspacing="0">
-        <tr>
-          <td valign="top">
-            <select name="component" id="component"
-                    size="5" onchange="PutDescription()">
-              [% IF NOT default.component_ %]
-                [%# Various b.m.o. products have a "General" component,
-                    which is a useful default. %]
-                [% default.component_ = "General" %]
-              [% END %]
-              [% FOREACH c = product.components %]
-                <option value="[% c.name FILTER html %]"
-                  [% " selected=\"selected\"" IF c.name == default.component_ %]>
-                  [% c.name FILTER html %]
-                </option>
-              [% END %]
-            </select>
-          </td>
-          <td valign="top" width="100%">
-              <div id="description" class="comment">
-                <script type="text/javascript">
-                  if ((document.getElementById) && (document.body.innerHTML)) {
-                    document.write("\
-                    Select a component to see its description here.");
-                  }
-                </script>
-              </div>
-          </td>
-        </tr>
-      </table>
-      
+    <th>Component</th>
+    <td>
+      <select name="component" id="component" size="5" onchange="PutDescription()">
+        [% IF NOT default.component_ %]
+          [% default.component_ = "General" %]
+        [% END %]
+        [% FOREACH c = product.components %]
+          <option value="[% c.name FILTER html %]"
+                  [%+ 'selected="selected"' IF c.name == default.component_ %]>
+            [% c.name FILTER html %]
+          </option>
+        [% END %]
+      </select>
+
+      <div id="description" class="comment">
+        <script type="text/javascript">
+          if ((document.getElementById) && (document.body.innerHTML)) {
+            document.write("Select a component to see its description here.");
+          }
+        </script>
+      </div>
+
       <p>
         The area where the problem occurs.
         To pick the right component, you could use the same one as
         similar [% terms.bugs %] you found in your search, or read the full list of
-        <a target="_blank" href="describecomponents.cgi?product=
-            [% product.name FILTER uri %]">component
-        descriptions</a> (opens in new window) if you need more help.
+        <a href="describecomponents.cgi?product=[% product.name FILTER uri %]"
+           target="_blank" >component descriptions</a> (opens in new window) if
+        you need more help.
       </p>
     </td>
   </tr>
 
-  [%# We override rep_platform and op_sys for simplicity. The values chosen
-      are based on which are most common in the b.m.o database %]
+  [%# We override rep_platform and op_sys for simplicity. %]
   [% rep_platform = [ "PC", "Macintosh", "All", "Other" ] %]
 
   <tr class="guided_form_field">
-    <td align="right" valign="top">
-      <b>[% field_descs.rep_platform FILTER html %]</b>
-    </td>
-    <td valign="top">
+    <th>[% field_descs.rep_platform FILTER html %]</th>
+    <td>
       [% PROCESS select sel = 'rep_platform' %]
     </td>
   </tr>
 
-  [% op_sys = [ "Windows 2000", "Windows XP", "Windows Vista", "Windows 7",
+  [% op_sys = [ "Windows XP", "Windows Vista", "Windows 7", "Windows 8",
                 "Mac OS X", "Linux", "All", "Other" ] %]
 
   <tr>
-    <td align="right" valign="top">
-      <b>Operating System</b>
-    </td>
-    <td valign="top">
+    <th>Operating System</th>
+    <td>
       [% PROCESS select sel = 'op_sys' %]
     </td>
   </tr>
 
-  [% IF product.name.match("Firefox|Camino|Mozilla Application Suite") %]
-    [% matches = cgi.user_agent('Gecko/(\d+)') %]
-    [% buildid = cgi.user_agent() IF matches %]
-  [% END %]
-  
   [%# Accept URL parameter build ID for non-browser products %]
   [% IF cgi.param("buildid") %]
     [% buildid = cgi.param("buildid") %]
   [% END %]
 
   <tr class="guided_form_field">
-    <td align="right" valign="top">
-      <b>Build Identifier</b>
-    </td>
-    <td valign="top">
+    <th>Build Identifier</th>
+    <td>
       <input type="text" size="80" name="buildid" value="[% buildid FILTER html %]">
       <p>
         This should identify the exact version of the product you were using.  
@@ -233,25 +188,18 @@ function PutDescription() {
   </tr>
 
   <tr>
-    <td align="right" valign="top">
-      <b>URL</b>
-    </td>
-    <td valign="top">
+    <th>URL</th>
+    <td>
       <input type="text" size="80" name="bug_file_loc" value="http://">
       <p>
-        URL that demonstrates the problem you are seeing (optional).<br>
-        <b>IMPORTANT</b>: if the problem is with a broken web page, you need
-        to report it
-        <a href="https://bugzilla.mozilla.org/page.cgi?id=broken-website.html">a different way</a>.
+        URL that demonstrates the problem you are seeing (optional).
       </p>
    </td>
   </tr>
 
   <tr class="guided_form_field">
-    <td align="right" valign="top">
-      <b>Summary</b>
-    </td>
-    <td valign="top">
+    <th>Summary</th>
+    <td>
       <input type="text" size="80" name="short_desc" id="short_desc" 
              maxlength="255" spellcheck="true">
       <p>
@@ -272,10 +220,8 @@ function PutDescription() {
   </tr>
 
   <tr>
-    <td align="right" valign="top">
-      <b>Details</b>
-    </td>
-    <td valign="top">
+    <th>Details</th>
+    <td>
       [% INCLUDE global/textarea.html.tmpl
         name    = 'comment'
         minrows = 6
@@ -302,10 +248,8 @@ function PutDescription() {
   </tr>
 
   <tr class="guided_form_field">
-    <td align="right" valign="top">
-      <b>Reproducibility</b>
-    </td>
-    <td valign="top">
+    <th>Reproducibility</th>
+    <td>
       <select name="reproducible">
         <option name="AlwaysReproducible" value="Always">
           Happens every time.
@@ -324,10 +268,8 @@ function PutDescription() {
   </tr>
 
   <tr>
-    <td align="right" valign="top">
-      <b>Steps to Reproduce</b>
-    </td>
-    <td valign="top">
+    <th>Steps to Reproduce</th>
+    <td>
       [% INCLUDE global/textarea.html.tmpl
         name           = 'reproduce_steps'
         minrows        = 4
@@ -342,10 +284,8 @@ function PutDescription() {
   </tr>
 
   <tr class="guided_form_field">
-    <td valign="top" align="right">
-      <b>Actual Results</b>
-    </td>
-    <td valign="top">
+    <th>Actual Results</th>
+    <td>
       [% INCLUDE global/textarea.html.tmpl
         name    = 'actual_results'
         minrows = 4
@@ -358,10 +298,8 @@ function PutDescription() {
   </tr>
 
   <tr>
-    <td valign="top" align="right">
-      <b>Expected Results</b>
-    </td>
-    <td valign="top">
+    <th>Expected Results</th>
+    <td>
       [% INCLUDE global/textarea.html.tmpl
         name    = 'expected_results'
         minrows = 4
@@ -374,10 +312,8 @@ function PutDescription() {
   </tr>
 
   <tr class="guided_form_field">
-    <td valign="top" align="right">
-      <b>Additional Information</b>
-    </td>
-    <td valign="top">
+    <th>Additional Information</th>
+    <td>
       [% INCLUDE global/textarea.html.tmpl
         name    = 'additional_info'
         minrows = 8
@@ -387,8 +323,7 @@ function PutDescription() {
         Add any additional information you feel may be
         relevant to this [% terms.bug %], such as the <b>theme</b> you were
         using (does the [% terms.bug %] still occur
-        with the default theme?), a 
-        <b><a href="http://kb.mozillazine.org/Quality_Feedback_Agent">Talkback crash ID</a></b>, or special
+        with the default theme?), or special
         information about <b>your computer's configuration</b>. Any information
         longer than a few lines, such as a <b>stack trace</b> or <b>HTML
         testcase</b>, should be added
@@ -406,10 +341,8 @@ function PutDescription() {
   </tr>
 
   <tr>
-    <td valign="top" align="right">
-      <b>[% field_descs.bug_severity FILTER html %]</b>
-    </td>
-    <td valign="top">
+    <th>[% field_descs.bug_severity FILTER html %]</th>
+    <td>
       <select name="bug_severity">
         <option name="critical" value="critical">
           Critical: The software crashes, hangs, or causes you to
diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl
index 0ddc7cc06..3b93ebe2b 100644
--- a/template/en/default/bug/edit.html.tmpl
+++ b/template/en/default/bug/edit.html.tmpl
@@ -113,7 +113,7 @@
       </td>
       [%# 2nd Column %]
       <td id="bz_show_bug_column_2" class="bz_show_bug_column">
-        <table cellpadding="3" cellspacing="1">
+        <table>
         [%# *** Reported and modified dates *** %]
          [% PROCESS section_dates %]
 
@@ -143,7 +143,8 @@
     </tr>
   </table>
 
-  <table id="bz_big_form_parts" cellspacing="0" cellpadding="0"><tr>
+  <table id="bz_big_form_parts">
+  <tr>
   <td>
     [% IF user.is_timetracker %]
       [% PROCESS section_timetracking %]
@@ -618,7 +619,7 @@
     <tr>
       <th>&nbsp;</th>
 
-      <td colspan="2" align="left" id="show_dependency_tree_or_graph">
+      <td colspan="2" id="show_dependency_tree_or_graph">
         Show dependency <a href="showdependencytree.cgi?id=[% bug.bug_id %]&amp;hide_resolved=1">tree</a>
 
         [% IF Param('webdotbase') %]
@@ -1123,8 +1124,7 @@
         <br>
         [% PROCESS commit_button id=""%]
 
-        <table id="bug_status_bottom"
-               class="status" cellspacing="0" cellpadding="0">
+        <table id="bug_status_bottom" class="status">
           <tr>
             <th class="field_label">
               <a href="page.cgi?id=fields.html#bug_status">Status</a>:
diff --git a/template/en/default/bug/process/verify-new-product.html.tmpl b/template/en/default/bug/process/verify-new-product.html.tmpl
index a1a9539f2..c562bf54d 100644
--- a/template/en/default/bug/process/verify-new-product.html.tmpl
+++ b/template/en/default/bug/process/verify-new-product.html.tmpl
@@ -18,7 +18,9 @@
   #%]
 
 [% PROCESS global/header.html.tmpl
-  title = 'Verify New Product Details...' %]
+  title = 'Verify New Product Details...'
+  style_urls = ['skins/standard/buglist.css']
+%]
 
 <form action="process_bug.cgi" method="post">
 
@@ -150,23 +152,23 @@
         }
       </script>
 
-      <table border="1">
+      <table id="groups_edit_multiple">
         <tr>
-          <th>Remove<br>[% terms.bugs %]<br>from this<br>group</th>
-          <th>Add<br>[% terms.bugs %]<br>to this<br>group</th>
-          <th>Group Name:</th>
+          <th class="narrow_column">Remove [% terms.bugs %] from this group</th>
+          <th class="narrow_column">Add [% terms.bugs %] to this group</th>
+          <th>Group Name</th>
         </tr>
 
         [% FOREACH group = optional_groups %]
         <tr>
-          <td align="center">
+          <td class="center">
             <input type="checkbox" name="defined_groups"
                    id="defined_group_[% group.group.id FILTER html %]"
                    value="[% group.group.name FILTER html %]"
                    [% IF cgi.param("defined_groups").contains(group.group.name) %] checked="checked"[% END %]
                    onchange="turn_off(this, 'group_[% group.group.id FILTER html %]')">
           </td>
-          <td align="center">
+          <td class="center">
             <input type="checkbox" name="groups"
                    id="group_[% group.group.id FILTER html %]"
                    value="[% group.group.name FILTER html %]"
diff --git a/template/en/default/bug/summarize-time.html.tmpl b/template/en/default/bug/summarize-time.html.tmpl
index ee654dc38..9a32c0a71 100644
--- a/template/en/default/bug/summarize-time.html.tmpl
+++ b/template/en/default/bug/summarize-time.html.tmpl
@@ -83,7 +83,7 @@
 
 [% BLOCK owner_report %]
     [% global.total = 0 global.bug_count = {} global.owner_count = {} %]
-    <table cellpadding="4" cellspacing="0" width="90%" class="realitems owner">
+    <table class="realitems owner">
         [% FOREACH owner = workdata.keys.sort %]
             [% INCLUDE do_one_owner owner=owner ownerdata=workdata.$owner
                                     detailed=detailed %]
@@ -128,7 +128,7 @@
 [% BLOCK number_report %]
     [% global.total = 0 global.owner_count = {} global.bug_count = {} %]
 
-    <table cellpadding="4" cellspacing="0" width="90%" class="realitems number">
+    <table class="realitems number">
     [% FOREACH bug = workdata.keys.nsort %]
         [% INCLUDE do_one_bug id=bug bugdata=workdata.$bug
                               detailed=detailed %]
@@ -188,7 +188,7 @@
       <tr class="bug_header[% '2' IF cid % 2 %]">
         <td>&nbsp;</td>
         <td colspan="3">
-          <table width="100%" cellpadding="0" cellspacing="0">
+          <table>
             <tr>
               <td width="33%">
                 Estimated: [% bugs.$id.estimated_time FILTER format("%.2f") %]h
@@ -222,7 +222,7 @@
 
 [% BLOCK inactive_report %]
     <h3>Inactive [% terms.bugs %]</h3>
-    <table cellpadding="4" cellspacing="0" width="90%" class="zeroitems">
+    <table class="zeroitems">
     [% cid = 0 %]
     [% FOREACH bug_id = null.nsort %]
         [% INCLUDE bug_header id=bug_id cid=cid %]
@@ -296,7 +296,7 @@
 </td></tr>
 <tr>
 <td>&nbsp;</td><td colspan="4">
-  <small>(Dates are optional, and in YYYY-MM-DD format)</small>
+  <span class="bz_info">(Dates are optional, and in YYYY-MM-DD format)</span>
 </td>
 <tr><td align="right">
   <b>Group by</b>: