Bug 317694: All buttons in forms must have an id - Patches by André Batosti <batosti@async.com.br> r=ghendricks a=myk

13 files changed, 24 insertions, 21 deletions

diff --git a/template/en/default/bug/choose.html.tmpl b/template/en/default/bug/choose.html.tmpl
index c3c2c59b5..65b260bb4 100644
--- a/template/en/default/bug/choose.html.tmpl
+++ b/template/en/default/bug/choose.html.tmpl
@@ -29,7 +29,7 @@
   <p>
     You may find a single [% terms.bug %] by entering its [% terms.bug %] id here:
     <input name="id" size="6">
-    <input type="submit" value="Show Me This [% terms.Bug %]">
+    <input type="submit" id="show" value="Show Me This [% terms.Bug %]">
   </p>
 </form>
 
diff --git a/template/en/default/bug/create/confirm-create-dupe.html.tmpl b/template/en/default/bug/create/confirm-create-dupe.html.tmpl
index ef3d1ff23..47d2ae916 100644
--- a/template/en/default/bug/create/confirm-create-dupe.html.tmpl
+++ b/template/en/default/bug/create/confirm-create-dupe.html.tmpl
@@ -48,7 +48,7 @@ FILTER bug_link(bugid) FILTER none %].</font></p>
     [% PROCESS "global/hidden-fields.html.tmpl"
                exclude="^(Bugzilla_login|Bugzilla_password|ignore_token)$" %]
     <input type="hidden" name="ignore_token" value="[% bugid FILTER html %]">
-    <input type="submit" value="File [% terms.bug %] again">
+    <input type="submit" value="File [% terms.bug %] again" id="file_bug_again">
   </form>
 [% END %]
 
diff --git a/template/en/default/bug/create/create-guided.html.tmpl b/template/en/default/bug/create/create-guided.html.tmpl
index 9b1cf39fe..ec74d4321 100644
--- a/template/en/default/bug/create/create-guided.html.tmpl
+++ b/template/en/default/bug/create/create-guided.html.tmpl
@@ -157,7 +157,7 @@ function PutDescription() {
     <input type="hidden" name="chfieldto" value="Now">
     <input type="hidden" name="chfield" value="[Bug creation]">
     <input type="text" name="content" size="40">
-    <input type="submit" value="Search">
+    <input type="submit" id="search" value="Search">
   </form>
 
 <p>
@@ -503,7 +503,7 @@ function PutDescription() {
 <h3>Step 3 of 3 - submit the [% terms.bug %] report</h3>
 
 <p>
-  <input type="submit" value="    Submit [% terms.Bug %] Report    "
+  <input type="submit" id="report" value="    Submit [% terms.Bug %] Report    "
    onclick="if (this.form.comment.value == '')
    { alert('Please enter some details about this [% terms.bug %].');
      this.form.comment.focus();
diff --git a/template/en/default/bug/create/create.html.tmpl b/template/en/default/bug/create/create.html.tmpl
index 38656b813..1749813e3 100644
--- a/template/en/default/bug/create/create.html.tmpl
+++ b/template/en/default/bug/create/create.html.tmpl
@@ -456,12 +456,12 @@ function handleWantsAttachment(wants_attachment) {
   <tr>
     <td></td>
     <td colspan="3">
-      <input type="submit" value="    Commit    "
+      <input type="submit" id="commit" value="    Commit    "
              onclick="if (this.form.short_desc.value == '')
              { alert('Please enter a summary sentence for this [% terms.bug %].');
                return false; } return true;">
       &nbsp;&nbsp;&nbsp;&nbsp;
-      <input type="submit" name="maketemplate"
+      <input type="submit" name="maketemplate" id="maketemplate"
              value="Remember values as bookmarkable template">
     </td>
   </tr>
diff --git a/template/en/default/bug/dependency-graph.html.tmpl b/template/en/default/bug/dependency-graph.html.tmpl
index 4db034ea2..48ca456c9 100644
--- a/template/en/default/bug/dependency-graph.html.tmpl
+++ b/template/en/default/bug/dependency-graph.html.tmpl
@@ -104,7 +104,7 @@
       </td>
     </tr>
   </table>
-  <input type="submit" value="Change Parameters">
+  <input type="submit" id="change" value="Change Parameters">
 </form>
 
 [% PROCESS global/footer.html.tmpl %]
diff --git a/template/en/default/bug/dependency-tree.html.tmpl b/template/en/default/bug/dependency-tree.html.tmpl
index 5c54f6fe1..b9f2cde39 100644
--- a/template/en/default/bug/dependency-tree.html.tmpl
+++ b/template/en/default/bug/dependency-tree.html.tmpl
@@ -171,7 +171,7 @@
        <input name="maxdepth" type="hidden" value="[% maxdepth %]">
      [% END %]
      <input type="hidden" name="hide_resolved" value="[% hide_resolved ? 0 : 1 %]">
-     <input type="submit" 
+     <input type="submit" id="toggle_visibility"
             value="[% IF hide_resolved %]Show[% ELSE %]Hide[% END %] Resolved">
    </form>
    </td>
@@ -188,7 +188,8 @@
    <form method="get" action="showdependencytree.cgi"
          style="display: inline; margin: 0px;">
      [%# set to one form %]
-     <input type="submit" value="&nbsp;1&nbsp;" 
+     <input type="submit" id="change_maxdepth"
+       value="&nbsp;1&nbsp;" 
        [% "disabled" IF realdepth < 2 || maxdepth == 1 %]>
      <input name="id" type="hidden" value="[% bugid %]">
      <input name="maxdepth" type="hidden" value="1">
@@ -207,7 +208,7 @@
                        : ( maxdepth ? maxdepth - 1 : realdepth - 1 )
      %]">
      <input name="hide_resolved" type="hidden" value="[% hide_resolved %]">
-     <input type="submit" value="&nbsp;&lt;&nbsp;" 
+     <input type="submit" id="decrase_depth" value="&nbsp;&lt;&nbsp;"
        [% "disabled" IF realdepth < 2 || ( maxdepth && maxdepth < 2 ) %]>
    </form>
    </td>
@@ -223,7 +224,8 @@
      <input name="id" type="hidden" value="[% bugid %]">
      <input name="hide_resolved" type="hidden" value="[% hide_resolved %]">
      <noscript>
-       <input type="submit" value="Change" [% "disabled" IF realdepth < 2 %]>
+       <input type="submit" id="change_depth" value="Change"
+              [% "disabled" IF realdepth < 2 %]>
      </noscript>
    </form>
    </td>
@@ -238,7 +240,7 @@
        <input name="maxdepth" type="hidden" value="[% maxdepth + 1 %]">
      [% END %]
      <input name="hide_resolved" type="hidden" value="[% hide_resolved %]">
-     <input type="submit" value="&nbsp;&gt;&nbsp;" 
+     <input type="submit" id="increase_depth" value="&nbsp;&gt;&nbsp;" 
         [% "disabled" IF realdepth < 2 || !maxdepth || maxdepth >= realdepth %]
     %]>
    </form>
@@ -250,7 +252,8 @@
      [%# Unlimited button %]
      <input name="id" type="hidden" value="[% bugid %]">
      <input name="hide_resolved" type="hidden" value="[% hide_resolved %]">
-     <input type="submit" value="&nbsp;Unlimited&nbsp;"
+     <input type="submit" id="remove_limit"
+       value="&nbsp;Unlimited&nbsp;"
        [% "disabled" IF maxdepth == 0 || maxdepth == realdepth %]>
    </form>
    </td>
diff --git a/template/en/default/bug/knob.html.tmpl b/template/en/default/bug/knob.html.tmpl
index 9f9e73f41..38a4898fe 100644
--- a/template/en/default/bug/knob.html.tmpl
+++ b/template/en/default/bug/knob.html.tmpl
@@ -154,7 +154,7 @@
     [% END %]
   [% END %]
 
-  <input type="submit" value="Commit">
+  <input type="submit" value="Commit" id="commit">
   <p>
     <font size="+1">
       <b>
@@ -173,7 +173,7 @@
 
     [% IF bug.user.canmove %]
       &nbsp; <font size="+1"><b> | </b></font> &nbsp;
-      <input type="submit" name="action"
+      <input type="submit" name="action" id="action"
              value="[% Param("move-button-text") %]">
     [% END %]
   </p>
diff --git a/template/en/default/bug/process/confirm-duplicate.html.tmpl b/template/en/default/bug/process/confirm-duplicate.html.tmpl
index 815b3d43c..4703af426 100644
--- a/template/en/default/bug/process/confirm-duplicate.html.tmpl
+++ b/template/en/default/bug/process/confirm-duplicate.html.tmpl
@@ -68,7 +68,7 @@
   <a href="show_bug.cgi?id=[% duplicate_bug_id %]">Throw away my changes,
     and revisit [% terms.bug %] [%+ duplicate_bug_id %]</a>
 <p>
-  <input type="submit" value="Submit">
+  <input type="submit" id="process" value="Submit">
 </p>
 
 </form>
diff --git a/template/en/default/bug/process/midair.html.tmpl b/template/en/default/bug/process/midair.html.tmpl
index aa587a4ca..620744bf7 100644
--- a/template/en/default/bug/process/midair.html.tmpl
+++ b/template/en/default/bug/process/midair.html.tmpl
@@ -77,7 +77,7 @@ You have the following choices:
   <li>
     <form method="post" action="process_bug.cgi">
       [% PROCESS "global/hidden-fields.html.tmpl" exclude="^Bugzilla_(login|password)$" %]
-      <input type="submit" value="Submit my changes anyway">
+      <input type="submit" id="process" value="Submit my changes anyway">
         This will cause all of the above changes to be overwritten
         [% ", except for the added comment(s)" IF comments.size > start_at %].
     </form>
diff --git a/template/en/default/bug/process/verify-new-product.html.tmpl b/template/en/default/bug/process/verify-new-product.html.tmpl
index 7e21f88ae..3b185993b 100644
--- a/template/en/default/bug/process/verify-new-product.html.tmpl
+++ b/template/en/default/bug/process/verify-new-product.html.tmpl
@@ -101,7 +101,7 @@
   </p>
 [% END %]
 
-<input type="submit" value="Commit">
+<input type="submit" id="change_product" value="Commit">
 
 </form>
 <hr>
diff --git a/template/en/default/bug/summarize-time.html.tmpl b/template/en/default/bug/summarize-time.html.tmpl
index bf4850153..8090aa319 100644
--- a/template/en/default/bug/summarize-time.html.tmpl
+++ b/template/en/default/bug/summarize-time.html.tmpl
@@ -268,7 +268,7 @@
   <input type="text" name="end_date" size="11" id="end_date"
   align="right" value ="[% end_date FILTER html %]" maxlength="10">
 </td><td align="right">
-  <input type="submit" value="Summarize">
+  <input type="submit" id="summarize" value="Summarize">
 </td></tr>
 <tr>
 <td>&nbsp;</td><td colspan="4">
diff --git a/template/en/default/bug/votes/delete-all.html.tmpl b/template/en/default/bug/votes/delete-all.html.tmpl
index 4c1173d54..ffede1db1 100644
--- a/template/en/default/bug/votes/delete-all.html.tmpl
+++ b/template/en/default/bug/votes/delete-all.html.tmpl
@@ -45,7 +45,7 @@
     No, go back and review my votes
   </p>
   <p>
-    <input type="submit" value="Submit">
+    <input type="submit" id="vote" value="Submit">
   </p>
 </form>
 
diff --git a/template/en/default/bug/votes/list-for-user.html.tmpl b/template/en/default/bug/votes/list-for-user.html.tmpl
index 85d25f9a2..7801b2a4a 100644
--- a/template/en/default/bug/votes/list-for-user.html.tmpl
+++ b/template/en/default/bug/votes/list-for-user.html.tmpl
@@ -146,7 +146,7 @@
     </table>
 
     [% IF canedit %]
-      <input type="submit" value="Change My Votes">
+      <input type="submit" value="Change My Votes" id="change">
       <br>
       <br>
       To change your votes,