summaryrefslogtreecommitdiffstats
path: root/whine.pl
diff options
context:
space:
mode:
authormkanat%bugzilla.org <>2009-07-07 20:16:51 +0200
committermkanat%bugzilla.org <>2009-07-07 20:16:51 +0200
commit89b15c8ff86238276de3428c379e46f7c04b6516 (patch)
tree43783cd8539a794b58ebe5b86dbfa7e43eaf143c /whine.pl
parent6a51c4c39e8ced6f808d5517d52c041d9305c2c0 (diff)
downloadbugzilla-89b15c8ff86238276de3428c379e46f7c04b6516.tar.gz
bugzilla-89b15c8ff86238276de3428c379e46f7c04b6516.tar.xz
Bug 491467: Make Search.pm and buglist.cgi consistently take column ids for the "fields" and "order" arguments, to prevent problems with using SQL fragments in the order and columnlist.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=wicked, a=mkanat
Diffstat (limited to 'whine.pl')
-rwxr-xr-xwhine.pl20
1 files changed, 10 insertions, 10 deletions
diff --git a/whine.pl b/whine.pl
index 36cf9c5af..b2508edc2 100755
--- a/whine.pl
+++ b/whine.pl
@@ -431,16 +431,16 @@ sub run_queries {
next unless $savedquery; # silently ignore missing queries
# Execute the saved query
- my @searchfields = (
- 'bugs.bug_id',
- 'bugs.bug_severity',
- 'bugs.priority',
- 'bugs.rep_platform',
- 'bugs.assigned_to',
- 'bugs.bug_status',
- 'bugs.resolution',
- 'bugs.short_desc',
- 'map_assigned_to.login_name',
+ my @searchfields = qw(
+ bug_id
+ bug_severity
+ priority
+ rep_platform
+ assigned_to
+ bug_status
+ resolution
+ short_desc
+ assigned_to
);
# A new Bugzilla::CGI object needs to be created to allow
# Bugzilla::Search to execute a saved query. It's exceedingly weird,