Bug 286235: Implicit joins should be replaced by explicit joins - installment A

Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk

1 files changed, 7 insertions, 5 deletions

diff --git a/whineatnews.pl b/whineatnews.pl
index d90e775fa..286b0c542 100755
--- a/whineatnews.pl
+++ b/whineatnews.pl
@@ -34,11 +34,13 @@ require "globals.pl";
 use Bugzilla::BugMail;
 
 my $dbh = Bugzilla->dbh;
-SendSQL("SELECT bug_id, short_desc, login_name FROM bugs, profiles WHERE " .
-        "(bug_status = 'NEW' OR bug_status = 'REOPENED') AND " . 
-        $dbh->sql_to_days('NOW()') . " - " .
-        $dbh->sql_to_days('delta_ts') . " > " . Param('whinedays') .
-        " AND userid = assigned_to ORDER BY bug_id");
+SendSQL("SELECT bug_id, short_desc, login_name " .
+        "FROM bugs INNER JOIN profiles ON userid = assigned_to " .
+        "WHERE (bug_status = 'NEW' OR bug_status = 'REOPENED') " .
+        "AND " . $dbh->sql_to_days('NOW()') . " - " .
+                 $dbh->sql_to_days('delta_ts') . " > " .
+                 Param('whinedays') . " " .
+        "ORDER BY bug_id");
 
 my %bugs;
 my %desc;