diff options
author | Max Kanat-Alexander <mkanat@bugzilla.org> | 2011-05-17 05:12:51 +0200 |
---|---|---|
committer | Max Kanat-Alexander <mkanat@bugzilla.org> | 2011-05-17 05:12:51 +0200 |
commit | cca5b123ae93a811b335815b0f754c4e4f44c8d4 (patch) | |
tree | 2a717c53176c162a8b4c0734ad55ab24083e219f /xt/lib/Bugzilla/Test/Search/Constants.pm | |
parent | a8c38773194820956e91b18735beb59e50a2686c (diff) | |
download | bugzilla-cca5b123ae93a811b335815b0f754c4e4f44c8d4.tar.gz bugzilla-cca5b123ae93a811b335815b0f754c4e4f44c8d4.tar.xz |
Bug 657542: Make the AND/OR tests for xt/search.t function properly and
catch known-broken tests as it's supposed to.
r=mkanat, a=mkanat (module owner)
Diffstat (limited to 'xt/lib/Bugzilla/Test/Search/Constants.pm')
-rw-r--r-- | xt/lib/Bugzilla/Test/Search/Constants.pm | 40 |
1 files changed, 3 insertions, 37 deletions
diff --git a/xt/lib/Bugzilla/Test/Search/Constants.pm b/xt/lib/Bugzilla/Test/Search/Constants.pm index a06ceecc7..512d180d9 100644 --- a/xt/lib/Bugzilla/Test/Search/Constants.pm +++ b/xt/lib/Bugzilla/Test/Search/Constants.pm @@ -46,7 +46,6 @@ our @EXPORT = qw( KNOWN_BROKEN NUM_BUGS NUM_SEARCH_TESTS - OR_BROKEN SKIP_FIELDS SPECIAL_PARAM_TESTS SUBSTR_NO_FIELD_ADD @@ -299,10 +298,10 @@ use constant KNOWN_BROKEN => { CHANGED_VALUE_BROKEN, # All fields should have a way to search for "changing # from a blank value" probably. - blocked => { contains => [3,4,5] }, - dependson => { contains => [2,4,5] }, + blocked => { contains => [3,4,5], no_criteria => 1 }, + dependson => { contains => [2,4,5], no_criteria => 1 }, work_time => { contains => [1] }, - FIELD_TYPE_BUG_ID, { contains => [5] }, + FIELD_TYPE_BUG_ID, { contains => [5], no_criteria => 1 }, }, # changeto doesn't find remaining_time changes (possibly due to us not # tracking that data properly). @@ -941,39 +940,6 @@ use constant INJECTION_TESTS => ( { value => '/*STAR_COMMENT_TEST' } ); -# This overrides KNOWN_BROKEN for OR configurations. -# It indicates that these combinations are broken in some way that they -# aren't broken when alone, because they don't return what they logically -# should when put into an OR. -use constant OR_BROKEN => { - # Multi-value fields search on individual values, so "equals" OR "notequals" - # returns nothing, when it should instead logically return everything. - 'blocked-equals' => { - 'blocked-notequals' => { contains => [1,2,3,4,5] }, - }, - 'dependson-equals' => { - 'dependson-notequals' => { contains => [1,2,3,4,5] }, - }, - 'bug_group-equals' => { - 'bug_group-notequals' => { contains => [1,2,3,4,5] }, - }, - 'cc-equals' => { - 'cc-notequals' => { contains => [1,2,3,4,5] }, - }, - 'commenter-equals' => { - 'commenter-notequals' => { contains => [1,2,3,4,5] }, - 'longdesc-notequals' => { contains => [2,3,4,5] }, - 'longdescs.isprivate-notequals' => { contains => [2,3,4,5] }, - 'work_time-notequals' => { contains => [2,3,4,5] }, - }, - 'commenter-notequals' => { - 'commenter-equals' => { contains => [1,2,3,4,5] }, - 'longdesc-equals' => { contains => [1] }, - 'longdescs.isprivate-equals' => { contains => [1] }, - 'work_time-equals' => { contains => [1] }, - }, -}; - ################# # Special Tests # ################# |