diff options
| -rw-r--r-- | .perlcriticrc | 2 | ||||
| -rw-r--r-- | Bugzilla/Quantum/CGI.pm | 14 | ||||
| -rw-r--r-- | Bugzilla/Quantum/Plugin/BlockIP.pm | 4 | ||||
| -rw-r--r-- | Bugzilla/Quantum/Plugin/Glue.pm | 6 |
4 files changed, 14 insertions, 12 deletions
diff --git a/.perlcriticrc b/.perlcriticrc index 0b8e4c862..d5fc03fa0 100644 --- a/.perlcriticrc +++ b/.perlcriticrc @@ -5,6 +5,8 @@ severity = 1 #perltidyrc = .perltidyrc #severity = 2 +[-CodeLayout::ProhibitParensWithBuiltins] + [InputOutput::RequireCheckedSyscalls] severity = 2 functions = :builtins diff --git a/Bugzilla/Quantum/CGI.pm b/Bugzilla/Quantum/CGI.pm index ab092140c..7585d888a 100644 --- a/Bugzilla/Quantum/CGI.pm +++ b/Bugzilla/Quantum/CGI.pm @@ -9,17 +9,17 @@ package Bugzilla::Quantum::CGI; use Mojo::Base 'Mojolicious::Controller'; use CGI::Compile; -use Bugzilla::Constants qw(bz_locations); -use Bugzilla::Quantum::Stdout; -use File::Slurper qw(read_text); -use File::Spec::Functions qw(catfile); -use Sub::Name; -use Sub::Quote 2.005000; use Try::Tiny; use Taint::Util qw(untaint); -use Socket qw(AF_INET inet_aton); use Sys::Hostname; +use Sub::Quote 2.005000; +use Sub::Name; +use Socket qw(AF_INET inet_aton); +use File::Spec::Functions qw(catfile); +use File::Slurper qw(read_text); use English qw(-no_match_vars); +use Bugzilla::Quantum::Stdout; +use Bugzilla::Constants qw(bz_locations); our $C; my %SEEN; diff --git a/Bugzilla/Quantum/Plugin/BlockIP.pm b/Bugzilla/Quantum/Plugin/BlockIP.pm index ebeb2a4aa..058ecbf64 100644 --- a/Bugzilla/Quantum/Plugin/BlockIP.pm +++ b/Bugzilla/Quantum/Plugin/BlockIP.pm @@ -34,8 +34,8 @@ sub _before_routes { if ( $MEMCACHED && $MEMCACHED->get("block_ip:$ip") ) { $c->block_ip($ip); $c->res->code(429); - $c->res->message("Too Many Requests"); - $c->res->body("Too Many Requests"); + $c->res->message('Too Many Requests'); + $c->res->body('Too Many Requests'); $c->finish; } } diff --git a/Bugzilla/Quantum/Plugin/Glue.pm b/Bugzilla/Quantum/Plugin/Glue.pm index f99026690..02514a0f8 100644 --- a/Bugzilla/Quantum/Plugin/Glue.pm +++ b/Bugzilla/Quantum/Plugin/Glue.pm @@ -48,7 +48,7 @@ sub register { sub { Bugzilla::RNG::srand(); srand(); - eval { Bugzilla->dbh->ping }; + try { Bugzilla->dbh->ping }; } ); @@ -69,9 +69,9 @@ sub register { Bugzilla::Extension->load_all(); if ( $app->mode ne 'development' ) { Bugzilla->preload_features(); - DEBUG("preloading templates"); + DEBUG('preloading templates'); Bugzilla->preload_templates(); - DEBUG("done preloading templates"); + DEBUG('done preloading templates'); } $app->secrets( [ Bugzilla->localconfig->{side_wide_secret} ] ); |